Home |
Search |
Today's Posts |
|
#1
![]()
Posted to microsoft.public.excel.programming
|
|||
|
|||
![]()
Your points are well taken. Thanks. Here is the amended code incorporating
your suggestions... Public Sub Username2Line() Dim rng As Range Dim IsCorrect As Boolean For Each rng In Range(Range("H2"), Cells(Rows.Count, "A"). _ End(xlUp).Offset(0, 7)) If Len(rng.Value) Then Select Case rng.Value Case "MFG1" IsCorrect = rng.Offset(0, 1).Value = "10FS" Case "MFG11" IsCorrect = rng.Offset(0, 1).Value = "80FS" Case "MFG15" IsCorrect = rng.Offset(0, 1).Value = "VTFS" Or _ rng.Offset(0, 1).Value = "TSFS" Or _ rng.Offset(0, 1).Value = "LUMFS" Case "MFG16" IsCorrect = rng.Offset(0, 1).Value = "STGFS" Case "MFG17" IsCorrect = rng.Offset(0, 1).Value = "35FS" Case "MFG18" IsCorrect = rng.Offset(0, 1).Value = "DPFS" Case "MFG4", "MFG7" IsCorrect = rng.Offset(0, 1).Value = "70FS" Case "MFG5" IsCorrect = rng.Offset(0, 1).Value = "VTFS" Case Else IsCorrect = False End Select If IsCorrect Then rng.Offset(0, 2).Value = "Correct" Else rng.Offset(0, 2).Value = "Incorrect Location" IsCorrect = False End If End If Next End Sub -- Rick (MVP - Excel) "Dana DeLouis" wrote in message ... Hi. Perhaps combine the two 70FS's. Case "MFG4", "MFG7" IsCorrect = rng.Offset(0, 1).Value = "70FS" Not sure how the data is set up, but it appears that the Op will have to make sure that at least one of the Cases is Run. (Perhaps add an Case Else) The reason is that if IsCorrect is set to True, and the next pass does not meet any Case Statements, then IsCorrect still remains set to True. Maybe... If IsCorrect Then rng.Offset(0, 2).Value = "Correct" IsCorrect = False Else ...etc = = = = = Just an idea. Dana DeLouis Rick Rothstein wrote: Code Correction. ====================== My previously posted code does not work; this modification to it does... Public Sub Username2Line() Dim rng As Range Dim IsCorrect As Boolean For Each rng In Range(Range("H2"), Cells(Rows.Count, "A"). _ End(xlUp).Offset(0, 7)) If Len(rng.Value) Then Select Case rng.Value Case "MFG1" IsCorrect = rng.Offset(0, 1).Value = "10FS" Case "MFG11" IsCorrect = rng.Offset(0, 1).Value = "80FS" Case "MFG15" IsCorrect = rng.Offset(0, 1).Value = "VTFS" Or _ rng.Offset(0, 1).Value = "TSFS" Or _ rng.Offset(0, 1).Value = "LUMFS" Case "MFG16" IsCorrect = rng.Offset(0, 1).Value = "STGFS" Case "MFG17" IsCorrect = rng.Offset(0, 1).Value = "35FS" Case "MFG18" IsCorrect = rng.Offset(0, 1).Value = "DPFS" Case "MFG4" IsCorrect = rng.Offset(0, 1).Value = "70FS" Case "MFG5" IsCorrect = rng.Offset(0, 1).Value = "VTFS" Case "MFG7" IsCorrect = rng.Offset(0, 1).Value = "70FS" End Select If IsCorrect Then rng.Offset(0, 2).Value = "Correct" Else rng.Offset(0, 2).Value = "Incorrect Location" End If End If Next End Sub |
Reply |
Thread Tools | Search this Thread |
Display Modes | |
|
|
![]() |
||||
Thread | Forum | |||
Can I use Select Case to do this? | Excel Programming | |||
Case without Select Case error problem | Excel Discussion (Misc queries) | |||
End Select without Select Case, Block If without End If errors | Excel Programming | |||
Case Select | Excel Programming |