Reply
 
LinkBack Thread Tools Search this Thread Display Modes
  #1   Report Post  
Posted to microsoft.public.word.vba.general,microsoft.public.excel.programming
external usenet poster
 
Posts: 120
Default How could I have saved memory?

I threw together a macro in Word 2007 yesterday, but it kept
interrupting. There was no error, but I'd get the annoying message
box that says "Code execution has been interrupted." and the CONTINUE,
END, and DEBUG buttons. I've learned this is usually an indication
that I'm stretching the capacity of my memory - all I have to do is
hit CONTINUE and it runs along just fine - until it interuupts again!!

I had tables in a Word doc with reprot numbers in one column, and
several more blank columns. The data to fill in those blanks was
mostly in an Excel spreadsheet. One blank, though, could only be
filled in by finding the report document and grabbing one line of
text.

So the macro was designed to set an object to the table I had selected
and iterate down the report numbers, open the spreadsheet and find the
needed values for that report, then open the report, grab the one line
of text, and close the report. Lather, rinse, repeat until the end of
the table.

Can someone see where I could have saved memory overhead and made this
run a bit smoother?

Ed


Sub EnterMyInfo()

Dim doc As Document
Dim tbl As Table
Dim str As String
Dim cll As Word.Cell

Dim tir As Document
Dim this As Range

Dim oXL As Excel.Application
Dim wkb As Excel.Workbook
Dim wks As Excel.Worksheet
Dim xlcll As Excel.Range

Dim x As Long, y As Long
Dim a As Long, b As Long
Dim vlu

Set doc = ActiveDocument
Set tbl = Selection.Tables(1)

Set oXL = New Excel.Application
Set wkb = oXL.Workbooks.Open("C:\MyFile.xls")
oXL.Visible = True

Set wks = wkb.Worksheets("Sheet1")
a = wks.Range("A20000").End(xlUp).Row

x = tbl.Rows.Count

For y = 1 To x
Application.StatusBar = "Row " & y & " of " & x
Set cll = tbl.Cell(y, 1)
If Left(cll.Range.Text, 5) = "L5-BB" Then
str = Left(cll.Range.Text, 10)

For b = 2 To a
If wks.Range("B" & b).Value = str Then Exit For
Next b

'Stop

'**********
'vlu was deliberately left undefined
'so I could adjust it depending on the table.
'**********

vlu = Format(wks.Cells(b, 3).Value, "mm/dd/yyyy")
tbl.Cell(y, 2).Range.Text = vlu
vlu = Format(wks.Cells(b, 5).Value, "####0.0")
tbl.Cell(y, 3).Range.Text = vlu
'tbl.Cell(y, 4).Range.Text = wks.Cells(b, 7).Value

Set tir = Word.Application.Documents.Open(FileName:="\\Serve r1\ &
str & ".doc")
tir.PageSetup.LeftMargin = InchesToPoints(0.75)
tir.PageSetup.RightMargin = InchesToPoints(0.75)

Set this = tir.Content
With this.Find
.Text = "|90. "
.Execute

this.Collapse wdCollapseEnd
this.MoveEndUntil "|", wdForward

tbl.Cell(y, 4).Range.Text = Trim(this.Text)
End With

'Stop

tir.Close wdDoNotSaveChanges
Set tir = Nothing

End If
Next y

EndMeNow:
On Error Resume Next
wkb.Close
oXL.Quit
Set oXL = Nothing
On Error GoTo 0

MsgBox "I'm done!"

End Sub
  #2   Report Post  
Posted to microsoft.public.word.vba.general,microsoft.public.excel.programming
external usenet poster
 
Posts: 32
Default How could I have saved memory?

On Jul 23, 10:07*am, Ed from AZ wrote:
I threw together a macro in Word 2007 yesterday, but it kept
interrupting. *There was no error, but I'd get the annoying message
box that says "Code execution has been interrupted." and the CONTINUE,
END, and DEBUG buttons. *I've learned this is usually an indication
that I'm stretching the capacity of my memory - all I have to do is
hit CONTINUE and it runs along just fine - until it interuupts again!!

I had tables in a Word doc with reprot numbers in one column, and
several more blank columns. *The data to fill in those blanks was
mostly in an Excel spreadsheet. *One blank, though, could only be
filled in by finding the report document and grabbing one line of
text.

So the macro was designed to set an object to the table I had selected
and iterate down the report numbers, open the spreadsheet and find the
needed values for that report, then open the report, grab the one line
of text, and close the report. *Lather, rinse, repeat until the end of
the table.

Can someone see where I could have saved memory overhead and made this
run a bit smoother?

Ed

Sub EnterMyInfo()

Dim doc As Document
Dim tbl As Table
Dim str As String
Dim cll As Word.Cell

Dim tir As Document
Dim this As Range

Dim oXL As Excel.Application
Dim wkb As Excel.Workbook
Dim wks As Excel.Worksheet
Dim xlcll As Excel.Range

Dim x As Long, y As Long
Dim a As Long, b As Long
Dim vlu

Set doc = ActiveDocument
Set tbl = Selection.Tables(1)

Set oXL = New Excel.Application
Set wkb = oXL.Workbooks.Open("C:\MyFile.xls")
oXL.Visible = True

Set wks = wkb.Worksheets("Sheet1")
a = wks.Range("A20000").End(xlUp).Row

x = tbl.Rows.Count

For y = 1 To x
* Application.StatusBar = "Row " & y & " of " & x
* Set cll = tbl.Cell(y, 1)
* If Left(cll.Range.Text, 5) = "L5-BB" Then
* * str = Left(cll.Range.Text, 10)

* * For b = 2 To a
* * * If wks.Range("B" & b).Value = str Then Exit For
* * Next b

* * 'Stop

* * '**********
* * 'vlu was deliberately left undefined
* * 'so I could adjust it depending on the table.
* * '**********

* * vlu = Format(wks.Cells(b, 3).Value, "mm/dd/yyyy")
* * tbl.Cell(y, 2).Range.Text = vlu
* * vlu = Format(wks.Cells(b, 5).Value, "####0.0")
* * tbl.Cell(y, 3).Range.Text = vlu
* * 'tbl.Cell(y, 4).Range.Text = wks.Cells(b, 7).Value

* * Set tir = Word.Application.Documents.Open(FileName:="\\Serve r1\ &
str & ".doc")
* * tir.PageSetup.LeftMargin = InchesToPoints(0.75)
* * tir.PageSetup.RightMargin = InchesToPoints(0.75)

* * Set this = tir.Content
* * With this.Find
* * * .Text = "|90. "
* * * .Execute

* * * this.Collapse wdCollapseEnd
* * * this.MoveEndUntil "|", wdForward

* * * tbl.Cell(y, 4).Range.Text = Trim(this.Text)
* * End With

* * 'Stop

* * tir.Close wdDoNotSaveChanges
* * Set tir = Nothing

* End If
Next y

EndMeNow:
On Error Resume Next
* wkb.Close
* oXL.Quit
* Set oXL = Nothing
On Error GoTo 0

MsgBox "I'm done!"

End Sub


Reboot your computer and try again... This happens to be more often
then I would like . Something is causing your code to automatically
break... It's nothing in the code it's self but rather something
stupid your computer did. You will find that after you reboot it will
work fine.

~ Cheers ~
  #3   Report Post  
Posted to microsoft.public.word.vba.general,microsoft.public.excel.programming
external usenet poster
 
Posts: 2
Default How could I have saved memory?


"Str" is a VBA function. Don't use it as a variable.
Set all of your Excel object variables to nothing.



"Ed from AZ"
wrote in message
I threw together a macro in Word 2007 yesterday, but it kept
interrupting. There was no error, but I'd get the annoying message
box that says "Code execution has been interrupted." and the CONTINUE,
END, and DEBUG buttons. I've learned this is usually an indication
that I'm stretching the capacity of my memory - all I have to do is
hit CONTINUE and it runs along just fine - until it interuupts again!!

I had tables in a Word doc with reprot numbers in one column, and
several more blank columns. The data to fill in those blanks was
mostly in an Excel spreadsheet. One blank, though, could only be
filled in by finding the report document and grabbing one line of
text.

So the macro was designed to set an object to the table I had selected
and iterate down the report numbers, open the spreadsheet and find the
needed values for that report, then open the report, grab the one line
of text, and close the report. Lather, rinse, repeat until the end of
the table.

Can someone see where I could have saved memory overhead and made this
run a bit smoother?

Ed
Reply
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules

Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
How do I recover an Excel document saved not saved as Darryl Excel Discussion (Misc queries) 6 January 5th 10 03:39 AM
XL 2007 - Out of Memory - memory leak/bug? PCLIVE Excel Discussion (Misc queries) 0 March 23rd 09 03:31 PM
(reposting) Memory problem: Out of Memory and cannot save WHA Excel Programming 0 November 30th 07 05:09 PM
Memory problem: Out of Memory and cannot save WHA Excel Programming 0 November 30th 07 03:52 AM
The instruction at "0x65255ac9" referenced memory at "0x00000008". The memory could not be read. Clikc OK to terminate etc Angus Comber[_2_] Excel Programming 1 November 7th 03 01:18 PM


All times are GMT +1. The time now is 03:42 AM.

Powered by vBulletin® Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Copyright ©2004-2024 ExcelBanter.
The comments are property of their posters.
 

About Us

"It's about Microsoft Excel"