LinkBack Thread Tools Search this Thread Display Modes
Prev Previous Post   Next Post Next
  #2   Report Post  
Posted to microsoft.public.excel.programming
external usenet poster
 
Posts: 34
Default What am I missing?

Met,

That code should work, though it could be tidied up with just one 'if'
statement:

Dim t As Long
For t = 1 To 9999
If Worksheets("SJournal").Cells(t, "A") = Worksheets("Invoice").Cells(t,
"B") Then
Worksheets("Invoice").Cells(t, "J") =
Worksheets("SJournal").Cells(t, "J")
Worksheets("Invoice").Cells(t, "K") =
Worksheets("SJournal").Cells(t, "K")
Worksheets("Invoice").Cells(t, "L") =
Worksheets("SJournal").Cells(t, "L")
Worksheets("Invoice").Cells(t, "M") =
Worksheets("SJournal").Cells(t, "M")
End If
Next t

However, doing 9999 rows, it will take some time to run (when you test the
code, start with a smaller number). It would be faster to read the data in
two arrays, modify the arrays then paste them back with something like:

Dim t As Long
Dim jrnlArr As Variant
Dim invArr As Variant

jrnlArr = Sheets("SJournal").Range("A1:M9999")
invArr = Sheets("Invoice").Range("A1:M9999")

For t = 1 To 9999
If jrnlArr(t, 1) = invArr(t, 2) Then
invArr(t, 10) = jrnlArr(t, 10)
invArr(t, 11) = jrnlArr(t, 11)
invArr(t, 12) = jrnlArr(t, 12)
invArr(t, 13) = jrnlArr(t, 13)
End If
Next t
Sheets("Invoice").Range("A1:M9999") = invArr


although this will only copy the cell contents across - no formatting will
be copied.

HTH

Tim


"Metrazal" wrote in
message ...

Ok,

With the following code, I want to copy columns J,K,L, & M from
"SJournal" if the cell in column "A" of "Sjournal" matches the cell in
column "B" of "Invoice". I am running this as a module since
"Sjournal" and "Invoice" are actually two seperate sheets. What am I
doing wrong or am I just really messed up with my concept?


For t = 1 To 9999
If Worksheets("SJournal").Cells(t, "A") =
Worksheets("Invoice").Cells(t, "B") Then Worksheets("Invoice").Cells(t,
"J") = Worksheets("SJournal").Cells(t, "J")
If Worksheets("SJournal").Cells(t, "A") =
Worksheets("Invoice").Cells(t, "B") Then Worksheets("Invoice").Cells(t,
"K") = Worksheets("SJournal").Cells(t, "K")
If Worksheets("SJournal").Cells(t, "A") =
Worksheets("Invoice").Cells(t, "B") Then Worksheets("Invoice").Cells(t,
"L") = Worksheets("SJournal").Cells(t, "L")
If Worksheets("SJournal").Cells(t, "A") =
Worksheets("Invoice").Cells(t, "B") Then Worksheets("Invoice").Cells(t,
"M") = Worksheets("SJournal").Cells(t, "M")
Next t


Thanks for any help in advance,

Met


--
Metrazal
------------------------------------------------------------------------
Metrazal's Profile:

http://www.excelforum.com/member.php...o&userid=31648
View this thread: http://www.excelforum.com/showthread...hreadid=516404



 
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules

Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
#missing! Arne Hegefors Excel Worksheet Functions 2 October 15th 08 05:50 PM
Something Missing Looping through Excel Worksheet Functions 4 December 18th 07 02:42 PM
Toolbars Missing, And option to Add Missing SmeetaG Excel Discussion (Misc queries) 3 October 19th 05 11:43 AM
On Error? Creates 1 missing worksheet then never detects any other missing worksheets Craigm[_35_] Excel Programming 2 August 1st 05 02:39 PM
Am I missing something??? Jody L. Whitlock Excel Programming 12 July 11th 05 06:15 AM


All times are GMT +1. The time now is 02:54 AM.

Powered by vBulletin® Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Copyright ©2004-2025 ExcelBanter.
The comments are property of their posters.
 

About Us

"It's about Microsoft Excel"