Home |
Search |
Today's Posts |
#4
![]()
Posted to microsoft.public.excel.programming
|
|||
|
|||
![]()
Ok, I tried what you had, and looking at it, it makes sense. But there is a problem and I am not sure what it is, or if I did something wrong. I tested it with 40 files and I know that total of these should at least force a third page. As results though, all I am getting is a complete copy of the first file, one line copied from each additional file and then a complete copy of the last file, all put in one list. I will look to see if I can figure out the error, but your further help would be appreciated
Thanks Ji ----- Dave Peterson wrote: ---- How about this Option Explici Sub CombineWorkbooks( Dim LastRow As Lon Dim basebook As Workboo Dim i As Lon Dim mybook As Workboo Dim DestCell As Rang Dim RngToCopy As Rang With Applicatio .DisplayAlerts = Fals .EnableEvents = Fals .ScreenUpdating = Fals End Wit With Application.FileSearc .NewSearc 'Change this to your director .LookIn = ThisWorkbook.Path & "\ProgramData\" .SearchSubFolders = Fals .FileType = msoFileTypeExcelWorkbook If .Execute() 0 The Set basebook = Workbooks.Open(.FoundFiles(1) With basebook.Worksheets(1 Set DestCell = .Cells(.Rows.Count, "A").End(xlUp End Wit For i = 2 To .FoundFiles.Coun Set mybook = Workbooks.Open(.FoundFiles(i) With ActiveShee 'column R = 18th colum Set RngToCopy = .Range("a1:R" & .Cells(.Rows.Count, "A").End(xlUp).Row End Wit If (DestCell.Row + RngToCopy.Rows.Count) < DestCell.Parent.Rows.Count The 'ok to paste, just come down one Set DestCell = DestCell.Offset(1, 0 Els 'too many rows, make a new shee Set DestCell = basebook.Worksheets.Add.Range("a1" End I RngToCopy.Copy Destination:=DestCel mybook.Clos Next 'ChDir ThisWorkbook.Path & "\ProgramData\FileData\Report\ ActiveWorkbook.SaveAs Filename:=ThisWorkbook.Path & "\ProgramData\FileData\Report\" & "Report1.xls", FileFormat:=xlText, CreateBackup:=Fals 'ActiveWorkbook.Close savechanges:=false 'just save End I End Wit With Applicatio .DisplayAlerts = Tru .EnableEvents = Tru End Wit End Su But this scares me 'ChDir ThisWorkbook.Path & "\ProgramData\FileData\Report\ ActiveWorkbook.SaveAs Filename:=ThisWorkbook.Path & "\ProgramData\FileData\Report\" & "Report1.xls", FileFormat:=xlText, CreateBackup:=Fals First, you don't need to change directories to save to that folder. Jus include it in the filename But you have it saving as xlText. I bet you want a normal workbook. xlNorma makes more sense to me James Stephens wrote I am looking for some advise on working around the excel row limit. I have the below formula that takes all workbooks in one folder, combines them into one new file and saves it into another folder. The issue is sometimes the amount of data will exceed the 65,536 row limitation. What I am looking for is a way to modify this so that if that limit is reached, a new sheet gets created and the data continues to be pasted into that sheet. This might need to go as high as four or five sheets. After that I have code that modifies this data considerably, but I think I can just use the code I have and modify it to do what it does to each sheet in the workbook instead of a specific worksheet I have searched around on google and haven't really found a way to modify this code. Any help would be great. I just need to find a way for this to simply create a new page when the limit is reached and continue copying and pasting data. Thanks for any assistance you can give me with this, below is a copy of the code as it stands now. Jim Sub CombineWorkbooks() Dim LastRow As Long Dim basebook As Workbook Dim i As Long Dim mybook As Workbook With Application .DisplayAlerts = False .EnableEvents = False .ScreenUpdating = False End With With Application.FileSearch .NewSearch 'Change this to your directory .LookIn = ThisWorkbook.Path & "\ProgramData\" .SearchSubFolders = False .FileType = msoFileTypeExcelWorkbooks If .Execute() 0 Then Set basebook = Workbooks.Open(.FoundFiles(1)) For i = 2 To .FoundFiles.Count Set mybook = Workbooks.Open(.FoundFiles(i)) With ActiveSheet LastRow = .Cells(.Rows.Count, "A").End(xlUp).Row .Range("a1").Resize(LastRow, 18).Copy _ basebook.Worksheets(1).Range("a1").End(xlDown).Off set(1, 0) End With mybook.Close Next i ChDir ThisWorkbook.Path & "\ProgramData\FileData\Report\" ActiveWorkbook.SaveAs FileName:="Report1.xls", FileFormat _ :=xlText, CreateBackup:=False ActiveWorkbook.Close End If End With With Application .DisplayAlerts = True .EnableEvents = True End With End Sub -- Dave Peterson |
Thread Tools | Search this Thread |
Display Modes | |
|
|
![]() |
||||
Thread | Forum | |||
Working Around 240 Character PRN Field Width Limit | Excel Discussion (Misc queries) | |||
how do i remove the limit set on the worskheet i am working on | Excel Discussion (Misc queries) | |||
Row limit in Excel | Excel Discussion (Misc queries) | |||
Row Limit in Excel | Excel Discussion (Misc queries) | |||
Nested IF limit or Open parentheses limit | Excel Discussion (Misc queries) |