Reply
 
LinkBack Thread Tools Search this Thread Display Modes
  #1   Report Post  
Posted to microsoft.public.excel.programming
external usenet poster
 
Posts: 178
Default on error help

Still can't figure this out... assume that all variables are properly
declared. When I comment ( ' ) out the on-error part, the code
operates properly, and if there is an error it will highlight the
MkDir foldername part. But when I make the on error codes active
again, it will execute msgbox and exit sub parts whether or not an
error occurs... What am I doing wrong?

SaveFile = Workbooks("worklist_detail_format_custom.xls").She ets
("sheet1").Range("D20")
MyPath = SaveFile


'Add a slash at the end if the user forget it
If Right(MyPath, 1) < "\" Then
MyPath = MyPath & "\"
End If

'Create folder for the new files
foldername = MyPath & Format(Now, "mm-dd-yyyy") & "\"

On Error Resume Next
MsgBox "The 'Save To Directory' in Worklist Detail Format Does Not
Exist" _
& vbNewLine & "Or A File With Today's Date Already Exists In the
Directory", vbOKOnly
Exit Sub
On Error GoTo 0

MkDir foldername
  #2   Report Post  
Posted to microsoft.public.excel.programming
external usenet poster
 
Posts: 703
Default on error help

Hi

The error will not occure before the MkDir statement, so the error
handling part sould come later.

Look at this:
sub aaa
SaveFile = Workbooks("worklist_detail_format_custom.xls").She ets
("sheet1").Range("D20")
MyPath = SaveFile

'Add a slash at the end if the user forget it
If Right(MyPath, 1) < "\" Then
MyPath = MyPath & "\"
End If

'Create folder for the new files
foldername = MyPath & Format(Now, "mm-dd-yyyy") & "\"

On Error GoTo ErrHandler
MkDir foldername
Exit Sub

ErrHandler:
MsgBox "The 'Save To Directory' in Worklist Detail Format Does Not "
Exist "" _
& vbNewLine & "Or A File With Today's Date Already Exists In the "
Directory ", vbOKOnly "
End Sub

Regards,
Per

On 13 Nov., 04:45, Matthew Dyer wrote:
Still can't figure this out... assume that all variables are properly
declared. When I comment ( ' ) out the on-error part, the code
operates properly, and if there is an error it will highlight the
MkDir foldername part. But when I make the on error codes active
again, it will execute msgbox and exit sub parts whether or not an
error occurs... What am I doing wrong?

* * SaveFile = Workbooks("worklist_detail_format_custom.xls").She ets
("sheet1").Range("D20")
* * MyPath = SaveFile

* * 'Add a slash at the end if the user forget it
* * If Right(MyPath, 1) < "\" Then
* * * * MyPath = MyPath & "\"
* * End If

* * 'Create folder for the new files
* * foldername = MyPath & Format(Now, "mm-dd-yyyy") & "\"

* * On Error Resume Next
* * MsgBox "The 'Save To Directory' in Worklist Detail Format Does Not
Exist" _
* * & vbNewLine & "Or A File With Today's Date Already Exists In the
Directory", vbOKOnly
* * Exit Sub
* * On Error GoTo 0

* * MkDir foldername


  #3   Report Post  
Posted to microsoft.public.excel.programming
external usenet poster
 
Posts: 178
Default on error help

On Nov 12, 8:55*pm, Per Jessen wrote:
Hi

The error will not occure before the MkDir statement, so the error
handling part sould come later.

Look at this:
sub aaa
SaveFile = Workbooks("worklist_detail_format_custom.xls").She ets
("sheet1").Range("D20")
MyPath = SaveFile

'Add a slash at the end if the user forget it
If Right(MyPath, 1) < "\" Then
* * MyPath = MyPath & "\"
End If

'Create folder for the new files
foldername = MyPath & Format(Now, "mm-dd-yyyy") & "\"

On Error GoTo ErrHandler
MkDir foldername
Exit Sub

ErrHandler:
MsgBox "The 'Save To Directory' in Worklist Detail Format Does Not "
Exist "" _
& vbNewLine & "Or A File With Today's Date Already Exists In the "
Directory ", vbOKOnly "
End Sub

Regards,
Per

On 13 Nov., 04:45, Matthew Dyer wrote:



Still can't figure this out... assume that all variables are properly
declared. When I comment ( ' ) out the on-error part, the code
operates properly, and if there is an error it will highlight the
MkDir foldername part. But when I make the on error codes active
again, it will execute msgbox and exit sub parts whether or not an
error occurs... What am I doing wrong?


* * SaveFile = Workbooks("worklist_detail_format_custom.xls").She ets
("sheet1").Range("D20")
* * MyPath = SaveFile


* * 'Add a slash at the end if the user forget it
* * If Right(MyPath, 1) < "\" Then
* * * * MyPath = MyPath & "\"
* * End If


* * 'Create folder for the new files
* * foldername = MyPath & Format(Now, "mm-dd-yyyy") & "\"


* * On Error Resume Next
* * MsgBox "The 'Save To Directory' in Worklist Detail Format Does Not
Exist" _
* * & vbNewLine & "Or A File With Today's Date Already Exists In the
Directory", vbOKOnly
* * Exit Sub
* * On Error GoTo 0


* * MkDir foldername- Hide quoted text -


- Show quoted text -


I tried the GoTo <label: but that isn't working for me either. It is
displaying the msgbox if there's an error or not...
  #4   Report Post  
Posted to microsoft.public.excel.programming
external usenet poster
 
Posts: 703
Default on error help

If you have an Exit Sub just before the ErrHandler: label, you will
only get the message if there is an error.

After the 'error message' try to insert the line below and see the
error in the Immediate window:

Debug.Print Err.Number & " " & Err.Description

Hopes this helps.
....
Per

On 13 Nov., 14:57, Matthew Dyer wrote:
On Nov 12, 8:55*pm, Per Jessen wrote:





Hi


The error will not occure before the MkDir statement, so the error
handling part sould come later.


Look at this:
sub aaa
SaveFile = Workbooks("worklist_detail_format_custom.xls").She ets
("sheet1").Range("D20")
MyPath = SaveFile


'Add a slash at the end if the user forget it
If Right(MyPath, 1) < "\" Then
* * MyPath = MyPath & "\"
End If


'Create folder for the new files
foldername = MyPath & Format(Now, "mm-dd-yyyy") & "\"


On Error GoTo ErrHandler
MkDir foldername
Exit Sub


ErrHandler:
MsgBox "The 'Save To Directory' in Worklist Detail Format Does Not "
Exist "" _
& vbNewLine & "Or A File With Today's Date Already Exists In the "
Directory ", vbOKOnly "
End Sub


Regards,
Per


On 13 Nov., 04:45, Matthew Dyer wrote:


Still can't figure this out... assume that all variables are properly
declared. When I comment ( ' ) out the on-error part, the code
operates properly, and if there is an error it will highlight the
MkDir foldername part. But when I make the on error codes active
again, it will execute msgbox and exit sub parts whether or not an
error occurs... What am I doing wrong?


* * SaveFile = Workbooks("worklist_detail_format_custom.xls").She ets
("sheet1").Range("D20")
* * MyPath = SaveFile


* * 'Add a slash at the end if the user forget it
* * If Right(MyPath, 1) < "\" Then
* * * * MyPath = MyPath & "\"
* * End If


* * 'Create folder for the new files
* * foldername = MyPath & Format(Now, "mm-dd-yyyy") & "\"


* * On Error Resume Next
* * MsgBox "The 'Save To Directory' in Worklist Detail Format Does Not
Exist" _
* * & vbNewLine & "Or A File With Today's Date Already Exists In the
Directory", vbOKOnly
* * Exit Sub
* * On Error GoTo 0


* * MkDir foldername- Hide quoted text -


- Show quoted text -


I tried the GoTo <label: but that isn't working for me either. It is
displaying the msgbox if there's an error or not...- Skjul tekst i anførselstegn -

- Vis tekst i anførselstegn -


  #5   Report Post  
Posted to microsoft.public.excel.programming
external usenet poster
 
Posts: 82
Default on error help

Why use On Error in the first place?

Couldn't you just check for the existence of the directory using the
Dir function with the 2nd argument set to vbDirectory?



Reply
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules

Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
Error when cell A1 is not active and xlInsideVertical border formatthrowing error 1004 [email protected] Excel Programming 7 August 7th 08 08:43 PM
Error handling error # 1004 Run-time error [email protected] Excel Programming 3 May 20th 08 02:23 PM
Error Handling - On Error GoTo doesn't trap error successfully David Excel Programming 9 February 16th 06 05:59 PM
Form Err.Raise error not trapped by entry procedure error handler [email protected] Excel Programming 1 February 8th 06 10:19 AM
Automation Error, Unknown Error. Error value - 440 Neo[_2_] Excel Programming 0 May 29th 04 05:26 AM


All times are GMT +1. The time now is 04:05 AM.

Powered by vBulletin® Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Copyright ©2004-2025 ExcelBanter.
The comments are property of their posters.
 

About Us

"It's about Microsoft Excel"