Hi ! I am trying to call a function in a sub. However there is some error,
Compilation error, sub function or property expected. What am I doing wrong?

In the sub:

StrikePrice (secID)

.....and the function
Public Function StrikePrice(secID As String) As String
secID = Split(secID, " ")(1)
If InStr(secID, "C") Then
secID = Split(secID, "C")(1)
Else
If InStr(secID, "P") Then
secID = Split(secID, "P")(1)
Else
MsgBox "Error"
End If
End If
StrikePrice = secID
End Function

Remove As String from the end of the Public Function line.

Ian

"Arne Hegefors" wrote in message
...
Hi ! I am trying to call a function in a sub. However there is some error,
Compilation error, sub function or property expected. What am I doing
wrong?

In the sub:

StrikePrice (secID)

....and the function
Public Function StrikePrice(secID As String) As String
secID = Split(secID, " ")(1)
If InStr(secID, "C") Then
secID = Split(secID, "C")(1)
Else
If InStr(secID, "P") Then
secID = Split(secID, "P")(1)
Else
MsgBox "Error"
End If
End If
StrikePrice = secID
End Function

By doing that the function will just return a variant. Generally not a good
idea unless you mean to return a variant. Additionally I fail to see how that
will resolve the issue.
--
HTH...

Jim Thomlinson


"Ian" wrote:

Remove As String from the end of the Public Function line.

Ian

"Arne Hegefors" wrote in message
...
Hi ! I am trying to call a function in a sub. However there is some error,
Compilation error, sub function or property expected. What am I doing
wrong?

In the sub:

StrikePrice (secID)

....and the function
Public Function StrikePrice(secID As String) As String
secID = Split(secID, " ")(1)
If InStr(secID, "C") Then
secID = Split(secID, "C")(1)
Else
If InStr(secID, "P") Then
secID = Split(secID, "P")(1)
Else
MsgBox "Error"
End If
End If
StrikePrice = secID
End Function

Either drop the ()'s
StrikePrice SecID
or add Call
Call StrikePrice(SecID)



Arne Hegefors wrote:

Hi ! I am trying to call a function in a sub. However there is some error,
Compilation error, sub function or property expected. What am I doing wrong?

In the sub:

StrikePrice (secID)

....and the function
Public Function StrikePrice(secID As String) As String
secID = Split(secID, " ")(1)
If InStr(secID, "C") Then
secID = Split(secID, "C")(1)
Else
If InStr(secID, "P") Then
secID = Split(secID, "P")(1)
Else
MsgBox "Error"
End If
End If
StrikePrice = secID
End Function

--

Dave Peterson

While your solution will resove the error, it will (I believe based on the
code posted) cause the function to do nothing truely productive. It is a true
function in that it just returns a value without changing anything else. If
Arne does not capture the return value then what was the point of calling the
function.
--
HTH...

Jim Thomlinson


"Dave Peterson" wrote:

Either drop the ()'s
StrikePrice SecID
or add Call
Call StrikePrice(SecID)



Arne Hegefors wrote:

Hi ! I am trying to call a function in a sub. However there is some error,
Compilation error, sub function or property expected. What am I doing wrong?

In the sub:

StrikePrice (secID)

....and the function
Public Function StrikePrice(secID As String) As String
secID = Split(secID, " ")(1)
If InStr(secID, "C") Then
secID = Split(secID, "C")(1)
Else
If InStr(secID, "P") Then
secID = Split(secID, "P")(1)
Else
MsgBox "Error"
End If
End If
StrikePrice = secID
End Function

--

Dave Peterson

Scratch that last post... SecId is passed by Ref and not by Value. SecId will
change... Time for me to get another cup of coffee. :-)
--
HTH...

Jim Thomlinson


"Jim Thomlinson" wrote:

While your solution will resove the error, it will (I believe based on the
code posted) cause the function to do nothing truely productive. It is a true
function in that it just returns a value without changing anything else. If
Arne does not capture the return value then what was the point of calling the
function.
--
HTH...

Jim Thomlinson


"Dave Peterson" wrote:

Either drop the ()'s
StrikePrice SecID
or add Call
Call StrikePrice(SecID)



Arne Hegefors wrote:

Hi ! I am trying to call a function in a sub. However there is some error,
Compilation error, sub function or property expected. What am I doing wrong?

In the sub:

StrikePrice (secID)

....and the function
Public Function StrikePrice(secID As String) As String
secID = Split(secID, " ")(1)
If InStr(secID, "C") Then
secID = Split(secID, "C")(1)
Else
If InStr(secID, "P") Then
secID = Split(secID, "P")(1)
Else
MsgBox "Error"
End If
End If
StrikePrice = secID
End Function

--

Dave Peterson

Works for me...

Sub test()
Dim str As String

str = StrikePrice("Puppy Cat Dog")
End Sub

Public Function StrikePrice(secID As String) As String
secID = Split(secID, " ")(1)
If InStr(secID, "C") Then
secID = Split(secID, "C")(1)
Else
If InStr(secID, "P") Then
secID = Split(secID, "P")(1)
Else
MsgBox "Error"
End If
End If
StrikePrice = secID
End Function

The one thing that I notice is that your function returns a string but in
the code you posted you were not assigning the return value "StrikePrice
(secID)"
--
HTH...

Jim Thomlinson


"Arne Hegefors" wrote:

Hi ! I am trying to call a function in a sub. However there is some error,
Compilation error, sub function or property expected. What am I doing wrong?

In the sub:

StrikePrice (secID)

....and the function
Public Function StrikePrice(secID As String) As String
secID = Split(secID, " ")(1)
If InStr(secID, "C") Then
secID = Split(secID, "C")(1)
Else
If InStr(secID, "P") Then
secID = Split(secID, "P")(1)
Else
MsgBox "Error"
End If
End If
StrikePrice = secID
End Function