Hi,

I have problems finding out what`s wrong with my code. Could someone
help me solve my problem. I think is something to do with "Thisfile".
Thanks.


Sub Save_workbook()

Dim resultat As String
Dim sDate As String
Dim myPath As String
Dim Thisfile As String

sDate = ActiveSheet.Range("B1")

Thisfile = "FFS2 graf" + " " + sDate + " " + ".xls"

myPath = "[file path\]"

Application.DisplayAlerts = False

resultat = MsgBox("Vil du lagre" + " " + Thisfile, vbYesNoCancel)
If resultat = vbYes Then

'ChDrive "c"
'ChDir ""

ActiveWorkbook.SaveAs FileName:=Thisfile & myPath --' Get pop up
that`s something wrong here --

Application.DisplayAlerts = True


Else
If resultat = vbNo Then


End If
End If

End Sub


--
joa
------------------------------------------------------------------------
joa's Profile: http://www.excelforum.com/member.php...o&userid=32933
View this thread: http://www.excelforum.com/showthread...hreadid=527571

Change "+" to "&"

for best results. & is a better concatenation operator

--
Regards,
Tom Ogilvy


"joa" wrote:


Hi,

I have problems finding out what`s wrong with my code. Could someone
help me solve my problem. I think is something to do with "Thisfile".
Thanks.


Sub Save_workbook()

Dim resultat As String
Dim sDate As String
Dim myPath As String
Dim Thisfile As String

sDate = ActiveSheet.Range("B1")

Thisfile = "FFS2 graf" + " " + sDate + " " + ".xls"

myPath = "[file path\]"

Application.DisplayAlerts = False

resultat = MsgBox("Vil du lagre" + " " + Thisfile, vbYesNoCancel)
If resultat = vbYes Then

'ChDrive "c"
'ChDir ""

ActiveWorkbook.SaveAs FileName:=Thisfile & myPath --' Get pop up
that`s something wrong here --

Application.DisplayAlerts = True


Else
If resultat = vbNo Then


End If
End If

End Sub


--
joa
------------------------------------------------------------------------
joa's Profile: http://www.excelforum.com/member.php...o&userid=32933
View this thread: http://www.excelforum.com/showthread...hreadid=527571

Joa,

Try this line:

ActiveWorkbook.SaveAs Filename:=myPath & "\" & Thisfile

For the same/similar purpose I use the following (origin: this NG with minos
mods):

Public Sub SaveASafetyCopy()
Dim strDate As String
Dim MyPath, MyName
MyPath = Application.ActiveWorkbook.Path
Count = Len(ActiveWorkbook.Name)
MyName = Left(ActiveWorkbook.Name, Count - 4)
strDate = Format(Date, "yyyy-mm-dd")
ActiveWorkbook.SaveCopyAs Filename:=MyPath & "\" & MyName & "-" & strDate &
".xls"
End Sub

Gábor


"joa" az alábbiakat írta
a következõ hírüzenetben:
...

Hi,

I have problems finding out what`s wrong with my code. Could someone
help me solve my problem. I think is something to do with "Thisfile".
Thanks.


Sub Save_workbook()

Dim resultat As String
Dim sDate As String
Dim myPath As String
Dim Thisfile As String

sDate = ActiveSheet.Range("B1")

Thisfile = "FFS2 graf" + " " + sDate + " " + ".xls"

myPath = "[file path\]"

Application.DisplayAlerts = False

resultat = MsgBox("Vil du lagre" + " " + Thisfile, vbYesNoCancel)
If resultat = vbYes Then

'ChDrive "c"
'ChDir ""

ActiveWorkbook.SaveAs FileName:=Thisfile & myPath --' Get pop up
that`s something wrong here --

Application.DisplayAlerts = True


Else
If resultat = vbNo Then


End If
End If

End Sub


--
joa
------------------------------------------------------------------------
joa's Profile:
http://www.excelforum.com/member.php...o&userid=32933
View this thread: http://www.excelforum.com/showthread...hreadid=527571

Hi,

I tried to change the way you guys told me to do it, but I still get
the same error msgbox. Thanks anyway.

Sub Save_workbook()

Dim resultat As String
Dim sDate As String
Dim myPath As String
Dim Thisfile As String

sDate = ActiveSheet.Range("B1")

Thisfile = "FFS2 graf" & " " & sDate & " " & ".xls"

myPath = "C:\Documents and Settings\krsjou\My Documents\FFS ferdig
grafer"

Application.DisplayAlerts = False

resultat = MsgBox("Vil du lagre" + " " + Thisfile, vbYesNoCancel)
If resultat = vbYes Then

'ChDrive "c"
'ChDir ""
ActiveWorkbook.SaveAs FileName:=myPath & "\" & Thisfile

Application.DisplayAlerts = True


Else
If resultat = vbNo Then


End If
End If

End Sub


+-------------------------------------------------------------------+
|Filename: msgbox.zip |
|Download: http://www.excelforum.com/attachment.php?postid=4546 |
+-------------------------------------------------------------------+

--
joa
------------------------------------------------------------------------
joa's Profile: http://www.excelforum.com/member.php...o&userid=32933
View this thread: http://www.excelforum.com/showthread...hreadid=527571

Hi Joa,

resultat = MsgBox("Vil du lagre" + " " + Thisfile, vbYesNoCancel)

You should implement Tom's suggestion and change "+" to "&"

However, your code works for me.

What error are you receiving and which line of code is highlighted?


---
Regards,
Norman



"joa" wrote in message
...

Hi,

I tried to change the way you guys told me to do it, but I still get
the same error msgbox. Thanks anyway.

Sub Save_workbook()

Dim resultat As String
Dim sDate As String
Dim myPath As String
Dim Thisfile As String

sDate = ActiveSheet.Range("B1")

Thisfile = "FFS2 graf" & " " & sDate & " " & ".xls"

myPath = "C:\Documents and Settings\krsjou\My Documents\FFS ferdig
grafer"

Application.DisplayAlerts = False

resultat = MsgBox("Vil du lagre" + " " + Thisfile, vbYesNoCancel)
If resultat = vbYes Then

'ChDrive "c"
'ChDir ""
ActiveWorkbook.SaveAs FileName:=myPath & "\" & Thisfile

Application.DisplayAlerts = True


Else
If resultat = vbNo Then


End If
End If

End Sub


+-------------------------------------------------------------------+
|Filename: msgbox.zip |
|Download: http://www.excelforum.com/attachment.php?postid=4546 |
+-------------------------------------------------------------------+

--
joa
------------------------------------------------------------------------
joa's Profile:
http://www.excelforum.com/member.php...o&userid=32933
View this thread: http://www.excelforum.com/showthread...hreadid=527571