Home |
Search |
Today's Posts |
#5
![]()
Posted to microsoft.public.excel.programming
|
|||
|
|||
![]()
Thank you very much Patrick,
Since you are the MS MVP, you should know the best...:) But I am an old programmer from thouse old DOS days...:) Just a newbee on Excel programming. Regards J_J "Patrick Molloy" wrote in message ... 1) you don't need wb2 or strFilename2 as you don't need to have them both open 2) your DIM statements are wrong. You have: Dim strFileName1, strFileName2 As String Dim wb1, wb2 As Workbook This is the same as: Dim strFileName1 AS VARIANT, strFileName2 As String Dim wb1 AS VARIANT, wb2 As Workbook -- if not explicitly dimensioned, then Variant is the default. Your code looks like an old DOS BASIC ;) they should be Dim strFileName1 As String, strFileName2 As String Dim wb1 As Workbook, wb2 As Workbook regards Patrick "J_J" wrote in message ... Hi Patrick, Thank you so much... Here is the working code with your solution alternative '----------------------------- Sub Macro1() Dim strFileName1, strFileName2 As String Dim wb1, wb2 As Workbook strFileName1 = Application.GetOpenFilename("Excel Templates (*.xlt), *.xlt") If strFileName1 = "" Then Exit Sub Set wb1 = Workbooks.Open(strFileName1) Application.Visible = False ThisWorkbook.Worksheets("Sheet1").Range("B1:B10"). Value = wb1.Worksheets("Sheet13").Range("C21:C30").Value ' similar code lines with other Sheet range cells ThisWorkbook.Worksheets("Sheet1").Range("B80:B82") .Value = wb1.Worksheets("Sheet4").Range("G5:G7").Value wb1.Close False Set wb1 = Nothing Application.Visible = True strFileName2 = Application.GetOpenFilename("Excel Templates (*.xlt), *.xlt") If strFileName2 = "" Then Exit Sub Set wb2 = Workbooks.Open(strFileName2) Application.Visible = False ThisWorkbook.Worksheets("Sheet2").Range("B1:B10"). Value = wb2.Worksheets("Sheet13").Range("C21:C30").Value ' similar code lines with other Sheet range cells ThisWorkbook.Worksheets("Sheet2").Range("B80:B82") .Value = wb2.Worksheets("Sheet4").Range("G5:G7").Value wb2.Close False Set wb2 = Nothing Application.Visible = True Worksheets("Sheet3").Activate Worksheets("Sheet3").Range("A12") = strFileName1 Worksheets("Sheet3").Range("B12") = strFileName2 End Sub '----------------------------------------------- |
Thread Tools | Search this Thread |
Display Modes | |
|
|
![]() |
||||
Thread | Forum | |||
Excel 2007 Macro/Link Issue (apologies for cross-posting) | Links and Linking in Excel | |||
Apologies for triple post | New Users to Excel | |||
the owner of posting should be able to delete the posting | Excel Discussion (Misc queries) | |||
Apologies | Excel Programming | |||
My Apologies | Excel Programming |