Home |
Search |
Today's Posts |
#1
Posted to microsoft.public.excel.programming
|
|||
|
|||
Code
I have an error because my code is too large. I realize
that it may be coded inefficiently but any other advice except re-write the code? |
#2
Posted to microsoft.public.excel.programming
|
|||
|
|||
Code
Copy/paste it here.
-- Don Guillett SalesAid Software "Novice" wrote in message ... I have an error because my code is too large. I realize that it may be coded inefficiently but any other advice except re-write the code? |
#3
Posted to microsoft.public.excel.programming
|
|||
|
|||
Code
The code is to hide specific rows for printing and it is
written to do this for 50 worksheets (one procedure). I am not sure you really want me to paste it all on here. However, I have pasted the procedure for one worksheet. How can I get the same effect for multiple worksheets? Private Sub CommandButton9_Click() Application.ScreenUpdating = False Sheets("Equip 1 Task").Activate ActiveSheet.Unprotect "Han044" ActiveSheet.Range("T3").Select If Selection.Value < 1 Then GoTo Continue If Selection 0 Then End If 'BEGIN EQUIPMENT 'Begin Row 7 ActiveSheet.Range("A7").Select If Selection = "" Then With ActiveSheet .Rows("7:7").EntireRow.Hidden = True End With End If 'End Row 7 'Begin Row 8 ActiveSheet.Range("A8").Select If Selection = "" Then With ActiveSheet .Rows("8:8").EntireRow.Hidden = True End With End If 'End Row 8 'Begin Row 9 ActiveSheet.Range("A9").Select If Selection = "" Then With ActiveSheet .Rows("9:9").EntireRow.Hidden = True End With End If 'End Row 9 'Begin Row 10 ActiveSheet.Range("A10").Select If Selection = "" Then With ActiveSheet .Rows("10:10").EntireRow.Hidden = True End With End If 'End Row 10 'Begin Row 11 ActiveSheet.Range("A11").Select If Selection = "" Then With ActiveSheet .Rows("11:11").EntireRow.Hidden = True End With End If 'End Row 11 'Begin Row 12 ActiveSheet.Range("A12").Select If Selection = "" Then With ActiveSheet .Rows("12:12").EntireRow.Hidden = True End With End If 'End Row 12 'Begin Row 13 ActiveSheet.Range("A13").Select If Selection = "" Then With ActiveSheet .Rows("13:13").EntireRow.Hidden = True End With End If 'End Row 13 'Begin Row 14 ActiveSheet.Range("A14").Select If Selection = "" Then With ActiveSheet .Rows("14:14").EntireRow.Hidden = True End With End If 'End Row 14 'Begin Row 15 ActiveSheet.Range("A15").Select If Selection = "" Then With ActiveSheet .Rows("15:15").EntireRow.Hidden = True End With End If 'End Row 15 'Begin Row 16 ActiveSheet.Range("A16").Select If Selection = "" Then With ActiveSheet .Rows("16:16").EntireRow.Hidden = True End With End If 'End Row 16 'Begin Row 17 ActiveSheet.Range("A17").Select If Selection = "" Then With ActiveSheet .Rows("17:17").EntireRow.Hidden = True End With End If 'End Row 17 'Begin Row 18 ActiveSheet.Range("A18").Select If Selection = "" Then With ActiveSheet .Rows("18:18").EntireRow.Hidden = True End With End If 'End Row 18 'Begin Row 19 ActiveSheet.Range("A19").Select If Selection = "" Then With ActiveSheet .Rows("19:19").EntireRow.Hidden = True End With End If 'End Row 19 'Begin Row 20 ActiveSheet.Range("A20").Select If Selection = "" Then With ActiveSheet .Rows("20:20").EntireRow.Hidden = True End With End If 'End Row 20 'Begin Row 21 ActiveSheet.Range("A21").Select If Selection = "" Then With ActiveSheet .Rows("21:21").EntireRow.Hidden = True End With End If 'End Row 21 'Begin Row 22 ActiveSheet.Range("A22").Select If Selection = "" Then With ActiveSheet .Rows("22:22").EntireRow.Hidden = True End With End If 'End Row 22 'Begin Row 23 ActiveSheet.Range("A23").Select If Selection = "" Then With ActiveSheet .Rows("23:23").EntireRow.Hidden = True End With End If 'End Row 23 'Begin Row 24 ActiveSheet.Range("A24").Select If Selection = "" Then With ActiveSheet .Rows("24:24").EntireRow.Hidden = True End With End If 'End Row 24 'Begin Row 25 ActiveSheet.Range("A25").Select If Selection = "" Then With ActiveSheet .Rows("25:25").EntireRow.Hidden = True End With End If 'End Row 25 'Begin Row 26 ActiveSheet.Range("A26").Select If Selection = "" Then With ActiveSheet .Rows("26:26").EntireRow.Hidden = True End With End If 'End Row 26 'Begin Row 27 ActiveSheet.Range("A27").Select If Selection = "" Then With ActiveSheet .Rows("27:27").EntireRow.Hidden = True End With End If 'End Row 27 'Begin Row 28 ActiveSheet.Range("A28").Select If Selection = "" Then With ActiveSheet .Rows("28:28").EntireRow.Hidden = True End With End If 'End Row 28 'Begin Row 29 ActiveSheet.Range("A29").Select If Selection = "" Then With ActiveSheet .Rows("29:29").EntireRow.Hidden = True End With End If 'End Row 29 'Begin Row 30 ActiveSheet.Range("A30").Select If Selection = "" Then With ActiveSheet .Rows("30:30").EntireRow.Hidden = True End With End If 'End Row 30 'Begin Row 31 ActiveSheet.Range("A31").Select If Selection = "" Then With ActiveSheet .Rows("31:31").EntireRow.Hidden = True End With End If 'End Row 31 'END EQUIPMENT LISTING 'BEGIN OTHER TASKS 'Begin Row 33 ActiveSheet.Range("A33").Select If Selection = "" Then With ActiveSheet .Rows("33:33").EntireRow.Hidden = True End With End If 'End Row 33 'Begin Row 34 ActiveSheet.Range("A34").Select If Selection = "" Then With ActiveSheet .Rows("34:34").EntireRow.Hidden = True End With End If 'End Row 34 'Begin Row 35 ActiveSheet.Range("A35").Select If Selection = "" Then With ActiveSheet .Rows("35:35").EntireRow.Hidden = True End With End If 'End Row 35 'Begin Row 36 ActiveSheet.Range("A36").Select If Selection = "" Then With ActiveSheet .Rows("36:36").EntireRow.Hidden = True End With End If 'End Row 36 'Begin Row 37 ActiveSheet.Range("A37").Select If Selection = "" Then With ActiveSheet .Rows("37:37").EntireRow.Hidden = True End With End If 'End Row 37 'Begin Row 38 ActiveSheet.Range("A38").Select If Selection = "" Then With ActiveSheet .Rows("38:38").EntireRow.Hidden = True End With End If 'End Row 38 ' BEGIN MIDSEASON/INSPECTION 'Begin Row 41 ActiveSheet.Range("A41").Select If Selection = "" Then With ActiveSheet .Rows("41:41").EntireRow.Hidden = True End With End If 'End Row 41 'Begin Row 42 ActiveSheet.Range("A42").Select If Selection = "" Then With ActiveSheet .Rows("42:42").EntireRow.Hidden = True End With End If 'End Row 42 'Begin Row 43 ActiveSheet.Range("A43").Select If Selection = "" Then With ActiveSheet .Rows("43:43").EntireRow.Hidden = True End With End If 'End Row 43 'Begin Row 44 ActiveSheet.Range("A44").Select If Selection = "" Then With ActiveSheet .Rows("44:44").EntireRow.Hidden = True End With End If 'End Row 44 'Begin Row 45 ActiveSheet.Range("A45").Select If Selection = "" Then With ActiveSheet .Rows("45:45").EntireRow.Hidden = True End With End If 'End Row 45 'Begin Row 46 ActiveSheet.Range("A46").Select If Selection = "" Then With ActiveSheet .Rows("46:46").EntireRow.Hidden = True End With End If 'End Row 46 'Begin Row 47 ActiveSheet.Range("A47").Select If Selection = "" Then With ActiveSheet .Rows("47:47").EntireRow.Hidden = True End With End If 'End Row 47 'Begin Row 48 ActiveSheet.Range("A48").Select If Selection = "" Then With ActiveSheet .Rows("48:48").EntireRow.Hidden = True End With End If 'End Row 48 'Begin Row 49 ActiveSheet.Range("A49").Select If Selection = "" Then With ActiveSheet .Rows("49:49").EntireRow.Hidden = True End With End If 'End Row 49 'Begin Row 50 ActiveSheet.Range("A50").Select If Selection = "" Then With ActiveSheet .Rows("50:50").EntireRow.Hidden = True End With End If 'End Row 50 'Begin Row 51 ActiveSheet.Range("A51").Select If Selection = "" Then With ActiveSheet .Rows("51:51").EntireRow.Hidden = True End With End If 'End Row 51 'Begin Row 52 ActiveSheet.Range("A52").Select If Selection = "" Then With ActiveSheet .Rows("52:52").EntireRow.Hidden = True End With End If 'End Row 52 'Begin Row 53 ActiveSheet.Range("A53").Select If Selection = "" Then With ActiveSheet .Rows("53:53").EntireRow.Hidden = True End With End If 'End Row 53 'Begin Row 54 ActiveSheet.Range("A54").Select If Selection = "" Then With ActiveSheet .Rows("54:54").EntireRow.Hidden = True End With End If 'End Row 54 'Begin Row 55 ActiveSheet.Range("A55").Select If Selection = "" Then With ActiveSheet .Rows("55:55").EntireRow.Hidden = True End With End If 'End Row 55 'Begin Row 56 ActiveSheet.Range("A56").Select If Selection = "" Then With ActiveSheet .Rows("56:56").EntireRow.Hidden = True End With End If 'End Row 56 'Begin Row 57 ActiveSheet.Range("A57").Select If Selection = "" Then With ActiveSheet .Rows("57:57").EntireRow.Hidden = True End With End If 'End Row 57 'Begin Row 58 ActiveSheet.Range("A58").Select If Selection = "" Then With ActiveSheet .Rows("58:58").EntireRow.Hidden = True End With End If 'End Row 58 'Begin Row 59 ActiveSheet.Range("A59").Select If Selection = "" Then With ActiveSheet .Rows("59:59").EntireRow.Hidden = True End With End If 'End Row 59 'Begin Row 60 ActiveSheet.Range("A60").Select If Selection = "" Then With ActiveSheet .Rows("60:60").EntireRow.Hidden = True End With End If 'End Row 60 'Begin Row 61 ActiveSheet.Range("A61").Select If Selection = "" Then With ActiveSheet .Rows("61:61").EntireRow.Hidden = True End With End If 'End Row 61 'Begin Row 62 ActiveSheet.Range("A62").Select If Selection = "" Then With ActiveSheet .Rows("62:62").EntireRow.Hidden = True End With End If 'End Row 62 ' BEGIN SEASONAL/PREVENTIVE MAINTENANCE 'Begin Row 63 'Begin Row 64 ActiveSheet.Range("A64").Select If Selection = "" Then With ActiveSheet .Rows("64:64").EntireRow.Hidden = True End With End If 'End Row 64 'Begin Row 65 ActiveSheet.Range("A65").Select If Selection = "" Then With ActiveSheet .Rows("65:65").EntireRow.Hidden = True End With End If 'End Row 65 'Begin Row 66 ActiveSheet.Range("A66").Select If Selection = "" Then With ActiveSheet .Rows("66:66").EntireRow.Hidden = True End With End If 'End Row 66 'Begin Row 67 ActiveSheet.Range("A67").Select If Selection = "" Then With ActiveSheet .Rows("67:67").EntireRow.Hidden = True End With End If 'End Row 67 'Begin Row 68 ActiveSheet.Range("A68").Select If Selection = "" Then With ActiveSheet .Rows("68:68").EntireRow.Hidden = True End With End If 'End Row 68 'Begin Row 69 ActiveSheet.Range("A69").Select If Selection = "" Then With ActiveSheet .Rows("69:69").EntireRow.Hidden = True End With End If 'End Row 69 'Begin Row 70 ActiveSheet.Range("A70").Select If Selection = "" Then With ActiveSheet .Rows("70:70").EntireRow.Hidden = True End With End If 'End Row 70 'Begin Row 71 ActiveSheet.Range("A71").Select If Selection = "" Then With ActiveSheet .Rows("71:71").EntireRow.Hidden = True End With End If 'End Row 71 'Begin Row 72 ActiveSheet.Range("A72").Select If Selection = "" Then With ActiveSheet .Rows("72:72").EntireRow.Hidden = True End With End If 'End Row 72 'Begin Row 73 ActiveSheet.Range("A73").Select If Selection = "" Then With ActiveSheet .Rows("73:73").EntireRow.Hidden = True End With End If 'End Row 73 'Begin Row 74 ActiveSheet.Range("A74").Select If Selection = "" Then With ActiveSheet .Rows("74:74").EntireRow.Hidden = True End With End If 'End Row 74 'Begin Row 75 ActiveSheet.Range("A75").Select If Selection = "" Then With ActiveSheet .Rows("75:75").EntireRow.Hidden = True End With End If 'End Row 75 'Begin Row 76 ActiveSheet.Range("A76").Select If Selection = "" Then With ActiveSheet .Rows("76:76").EntireRow.Hidden = True End With End If 'End Row 76 'Begin Row 77 ActiveSheet.Range("A77").Select If Selection = "" Then With ActiveSheet .Rows("77:77").EntireRow.Hidden = True End With End If 'End Row 77 'Begin Row 78 ActiveSheet.Range("A78").Select If Selection = "" Then With ActiveSheet .Rows("78:78").EntireRow.Hidden = True End With End If 'End Row 78 'Begin Row 79 ActiveSheet.Range("A79").Select If Selection = "" Then With ActiveSheet .Rows("79:79").EntireRow.Hidden = True End With End If 'End Row 79 'Begin Row 80 ActiveSheet.Range("A80").Select If Selection = "" Then With ActiveSheet .Rows("80:80").EntireRow.Hidden = True End With End If 'End Row 80 'Begin Row 81 ActiveSheet.Range("A81").Select If Selection = "" Then With ActiveSheet .Rows("81:81").EntireRow.Hidden = True End With End If 'End Row 81 'Begin Row 82 ActiveSheet.Range("A82").Select If Selection = "" Then With ActiveSheet .Rows("82:82").EntireRow.Hidden = True End With End If 'End Row 82 'Begin Row 83 ActiveSheet.Range("A83").Select If Selection = "" Then With ActiveSheet .Rows("83:83").EntireRow.Hidden = True End With End If 'End Row 83 'Begin Row 84 ActiveSheet.Range("A84").Select If Selection = "" Then With ActiveSheet .Rows("84:84").EntireRow.Hidden = True End With End If 'End Row 84 'Begin Row 85 ActiveSheet.Range("A85").Select If Selection = "" Then With ActiveSheet .Rows("85:85").EntireRow.Hidden = True End With End If 'End Row 85 'Begin Row 86 ActiveSheet.Range("A86").Select If Selection = "" Then With ActiveSheet .Rows("86:86").EntireRow.Hidden = True End With End If 'End Row 86 'Begin Row 87 ActiveSheet.Range("A87").Select If Selection = "" Then With ActiveSheet .Rows("87:87").EntireRow.Hidden = True End With End If 'End Row 87 'Begin Row 88 ActiveSheet.Range("A88").Select If Selection = "" Then With ActiveSheet .Rows("88:88").EntireRow.Hidden = True End With End If 'End Row 88 'Begin Row 89 ActiveSheet.Range("A89").Select If Selection = "" Then With ActiveSheet .Rows("89:89").EntireRow.Hidden = True End With End If 'End Row 90 'Begin Row 90 ActiveSheet.Range("A90").Select If Selection = "" Then With ActiveSheet .Rows("90:90").EntireRow.Hidden = True End With End If 'End Row 90 'Begin Row 91 ActiveSheet.Range("A91").Select If Selection = "" Then With ActiveSheet .Rows("91:91").EntireRow.Hidden = True End With End If 'End Row 91 'Begin Row 92 ActiveSheet.Range("A92").Select If Selection = "" Then With ActiveSheet .Rows("92:92").EntireRow.Hidden = True End With End If 'End Row 92 'Begin Row 93 ActiveSheet.Range("A93").Select If Selection = "" Then With ActiveSheet .Rows("93:93").EntireRow.Hidden = True End With End If 'End Row 93 'Begin Row 94 ActiveSheet.Range("A94").Select If Selection = "" Then With ActiveSheet .Rows("94:94").EntireRow.Hidden = True End With End If 'End Row 94 'Begin Row 95 ActiveSheet.Range("A95").Select If Selection = "" Then With ActiveSheet .Rows("95:95").EntireRow.Hidden = True End With End If 'End Row 95 'Begin Row 96 ActiveSheet.Range("A96").Select If Selection = "" Then With ActiveSheet .Rows("96:96").EntireRow.Hidden = True End With End If 'End Row 96 'Begin Row 97 ActiveSheet.Range("A97").Select If Selection = "" Then With ActiveSheet .Rows("97:97").EntireRow.Hidden = True End With End If 'End Row 97 'Begin Row 98 ActiveSheet.Range("A98").Select If Selection = "" Then With ActiveSheet .Rows("98:98").EntireRow.Hidden = True End With End If 'End Row 98 'Begin Row 99 ActiveSheet.Range("A99").Select If Selection = "" Then With ActiveSheet .Rows("99:99").EntireRow.Hidden = True End With End If 'End Row 99 'Begin Row 100 ActiveSheet.Range("A100").Select If Selection = "" Then With ActiveSheet .Rows("100:100").EntireRow.Hidden = True End With End If 'End Row 100 'Begin Row 101 ActiveSheet.Range("A101").Select If Selection = "" Then With ActiveSheet .Rows("101:101").EntireRow.Hidden = True End With End If 'End Row 101 ActiveWindow.SelectedSheets.PrintOut Copies:=1, Collate:=True With ActiveSheet .Rows("7:7").EntireRow.Hidden = False .Rows("8:8").EntireRow.Hidden = False .Rows("9:9").EntireRow.Hidden = False .Rows("10:10").EntireRow.Hidden = False .Rows("11:11").EntireRow.Hidden = False .Rows("12:12").EntireRow.Hidden = False .Rows("13:13").EntireRow.Hidden = False .Rows("14:14").EntireRow.Hidden = False .Rows("15:15").EntireRow.Hidden = False .Rows("16:16").EntireRow.Hidden = False .Rows("17:17").EntireRow.Hidden = False .Rows("18:18").EntireRow.Hidden = False .Rows("19:19").EntireRow.Hidden = False .Rows("20:20").EntireRow.Hidden = False .Rows("21:21").EntireRow.Hidden = False .Rows("22:22").EntireRow.Hidden = False .Rows("23:23").EntireRow.Hidden = False .Rows("24:24").EntireRow.Hidden = False .Rows("25:25").EntireRow.Hidden = False .Rows("26:26").EntireRow.Hidden = False .Rows("27:27").EntireRow.Hidden = False .Rows("28:28").EntireRow.Hidden = False .Rows("29:29").EntireRow.Hidden = False .Rows("30:30").EntireRow.Hidden = False .Rows("31:31").EntireRow.Hidden = False .Rows("33:33").EntireRow.Hidden = False .Rows("34:34").EntireRow.Hidden = False .Rows("35:35").EntireRow.Hidden = False .Rows("36:36").EntireRow.Hidden = False .Rows("37:37").EntireRow.Hidden = False .Rows("38:38").EntireRow.Hidden = False .Rows("41:41").EntireRow.Hidden = False .Rows("42:42").EntireRow.Hidden = False .Rows("43:43").EntireRow.Hidden = False .Rows("44:44").EntireRow.Hidden = False .Rows("48:48").EntireRow.Hidden = False .Rows("49:49").EntireRow.Hidden = False .Rows("50:50").EntireRow.Hidden = False .Rows("51:51").EntireRow.Hidden = False .Rows("52:52").EntireRow.Hidden = False .Rows("53:53").EntireRow.Hidden = False .Rows("54:54").EntireRow.Hidden = False .Rows("55:55").EntireRow.Hidden = False .Rows("56:56").EntireRow.Hidden = False .Rows("57:57").EntireRow.Hidden = False .Rows("58:58").EntireRow.Hidden = False .Rows("59:59").EntireRow.Hidden = False .Rows("60:60").EntireRow.Hidden = False .Rows("61:61").EntireRow.Hidden = False .Rows("62:62").EntireRow.Hidden = False .Rows("64:64").EntireRow.Hidden = False .Rows("65:65").EntireRow.Hidden = False .Rows("66:66").EntireRow.Hidden = False .Rows("67:67").EntireRow.Hidden = False .Rows("68:68").EntireRow.Hidden = False .Rows("69:69").EntireRow.Hidden = False .Rows("70:70").EntireRow.Hidden = False .Rows("71:71").EntireRow.Hidden = False .Rows("72:72").EntireRow.Hidden = False .Rows("73:73").EntireRow.Hidden = False .Rows("74:74").EntireRow.Hidden = False .Rows("75:75").EntireRow.Hidden = False .Rows("76:76").EntireRow.Hidden = False .Rows("77:77").EntireRow.Hidden = False .Rows("78:78").EntireRow.Hidden = False .Rows("79:79").EntireRow.Hidden = False .Rows("80:80").EntireRow.Hidden = False .Rows("81:81").EntireRow.Hidden = False .Rows("82:82").EntireRow.Hidden = False .Rows("83:83").EntireRow.Hidden = False .Rows("84:84").EntireRow.Hidden = False .Rows("85:85").EntireRow.Hidden = False .Rows("86:86").EntireRow.Hidden = False .Rows("87:87").EntireRow.Hidden = False .Rows("88:88").EntireRow.Hidden = False .Rows("89:89").EntireRow.Hidden = False .Rows("90:90").EntireRow.Hidden = False .Rows("91:91").EntireRow.Hidden = False .Rows("92:92").EntireRow.Hidden = False .Rows("93:93").EntireRow.Hidden = False .Rows("94:94").EntireRow.Hidden = False .Rows("95:95").EntireRow.Hidden = False .Rows("96:96").EntireRow.Hidden = False .Rows("97:97").EntireRow.Hidden = False .Rows("98:98").EntireRow.Hidden = False .Rows("99:99").EntireRow.Hidden = False .Rows("100:100").EntireRow.Hidden = False .Rows("101:101").EntireRow.Hidden = False End With Continue: ActiveSheet.Protect ("Han044") Sheets("Home").Select End Sub -----Original Message----- Copy/paste it here. -- Don Guillett SalesAid Software "Novice" wrote in message ... I have an error because my code is too large. I realize that it may be coded inefficiently but any other advice except re-write the code? . |
#4
Posted to microsoft.public.excel.programming
|
|||
|
|||
Code
You asked for it...
Anders Silven "Don Guillett" skrev i meddelandet ... Copy/paste it here. -- Don Guillett SalesAid Software "Novice" wrote in message ... I have an error because my code is too large. I realize that it may be coded inefficiently but any other advice except re-write the code? |
#5
Posted to microsoft.public.excel.programming
|
|||
|
|||
Code
Hi,
There is no need for all that code. Generally, as soon as you start to repeat yourself (more or less) you should set up a loop. Specifically as in your example the code can be even more simplified. Test the following two lines in the Immediate Window in the VBA Editor: range("A7:A101").SpecialCells(xlCellTypeBlanks).En tireRow.Hidden = True ' print here range("A7:A101").EntireRow.Hidden = False The first line will hide all rows where the cell in column A is empty. The second line will unhide all rows. To run the code on multiple worksheets, set up a loop that references the worksheets, one by one, by name or number. HTH Anders Silven |
#6
Posted to microsoft.public.excel.programming
|
|||
|
|||
Code
|
#7
Posted to microsoft.public.excel.programming
|
|||
|
|||
Code
|
Reply |
Thread Tools | Search this Thread |
Display Modes | |
|
|
Similar Threads | ||||
Thread | Forum | |||
split post code (zip code) out of cell that includes full address | Excel Discussion (Misc queries) | |||
Code to conditional format all black after date specified in code? | Excel Discussion (Misc queries) | |||
Drop Down/List w/Code and Definition, only code entered when selec | Excel Worksheet Functions | |||
copying vba code to a standard code module | Excel Discussion (Misc queries) | |||
VBA code delete code but ask for password and unlock VBA protection | Excel Programming |