Reply
 
LinkBack Thread Tools Search this Thread Display Modes
  #1   Report Post  
Posted to microsoft.public.excel.misc
external usenet poster
 
Posts: 318
Default Macro works Macro does not work

Hello I have two macros, separately they work but when I combined them into
one macro it does not work. Below is the macro combined. Thank you for help
Private Sub Worksheet_Change(ByVal Target As Range)
'With Target
'If .Address < "$B$28" Then Exit Sub
'If .Value = " Agreement" Then
' Rows(32).Hidden = False
'Rows(33).Hidden = True
' Rows(39).Hidden = True
'ElseIf .Value = "Master Agreement" Then
' Rows(32).Hidden = True
' Rows(33).Hidden = False

'ElseIf (Range("S4") = "Yes") Then

'Sheets("Discount
").Range("90:90,93:93,95:95,129:129,159:159,161:16 1,162:162,164:164,165:165,166:166,168:168,171:171, 306:306,308:308,343:343,345:345,350:350").EntireRo w.Hidden = True
'Else

'Sheets("Discount
").Range("90:90,93:93,95:95,129:129,159:159,161:16 1,162:162,164:164,165:165,166:166,168:168,171:171, 306:306,308:308,343:343,345:345,350:350").EntireRo w.Hidden = False

'End If

'End With


'End Sub

  #2   Report Post  
Posted to microsoft.public.excel.misc
external usenet poster
 
Posts: 896
Default Macro works Macro does not work

1) are you sure you DON'T have all the apostrophes in the beginning of
each line? my advise would be to remove them

2) you miss "End If" statement after
'ElseIf .Value = "Master Agreement" Then
' Rows(32).Hidden = True
' Rows(33).Hidden = False

at least this is what i have noticed
  #3   Report Post  
Posted to microsoft.public.excel.misc
external usenet poster
 
Posts: 11,501
Default Macro works Macro does not work

good point i removed them and never mentioned it

Mike

"Jarek Kujawa" wrote:

1) are you sure you DON'T have all the apostrophes in the beginning of
each line? my advise would be to remove them

2) you miss "End If" statement after
'ElseIf .Value = "Master Agreement" Then
' Rows(32).Hidden = True
' Rows(33).Hidden = False

at least this is what i have noticed

  #4   Report Post  
Posted to microsoft.public.excel.misc
external usenet poster
 
Posts: 11,501
Default Macro works Macro does not work

Hi,

One typo theres a space in front of Agreement which I guess you
don't want but apart from that as long as cell B28 changes
then it works. What it won't do is run if S4 Changes. To make it run if B28
or S4 change then try this

If Intersect(Target, Range("B28,S4")) Is Nothing Then Exit Sub

Mike

"Wanna Learn" wrote:

Hello I have two macros, separately they work but when I combined them into
one macro it does not work. Below is the macro combined. Thank you for help
Private Sub Worksheet_Change(ByVal Target As Range)
'With Target
'If .Address < "$B$28" Then Exit Sub
'If .Value = " Agreement" Then
' Rows(32).Hidden = False
'Rows(33).Hidden = True
' Rows(39).Hidden = True
'ElseIf .Value = "Master Agreement" Then
' Rows(32).Hidden = True
' Rows(33).Hidden = False

'ElseIf (Range("S4") = "Yes") Then

'Sheets("Discount
").Range("90:90,93:93,95:95,129:129,159:159,161:16 1,162:162,164:164,165:165,166:166,168:168,171:171, 306:306,308:308,343:343,345:345,350:350").EntireRo w.Hidden = True
'Else

'Sheets("Discount
").Range("90:90,93:93,95:95,129:129,159:159,161:16 1,162:162,164:164,165:165,166:166,168:168,171:171, 306:306,308:308,343:343,345:345,350:350").EntireRo w.Hidden = False

'End If

'End With


'End Sub

  #5   Report Post  
Posted to microsoft.public.excel.misc
external usenet poster
 
Posts: 896
Default Macro works Macro does not work

sorry, forget about 2)
you have got Exit Sub in yr 1st "if"
Reply
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules

Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
Macro do works in excel... driller Excel Worksheet Functions 7 July 12th 07 02:56 PM
Macro works for some users and not others kfell Excel Discussion (Misc queries) 6 April 17th 07 02:41 PM
Email Macro only sometime works? PaulW Excel Discussion (Misc queries) 0 August 15th 06 10:22 AM
Macro works but buttons don't markvi Excel Discussion (Misc queries) 0 June 8th 06 09:19 PM
macro works for some users and doesn't for others Pooja Excel Discussion (Misc queries) 2 October 27th 05 08:27 PM


All times are GMT +1. The time now is 06:51 PM.

Powered by vBulletin® Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Copyright ©2004-2024 ExcelBanter.
The comments are property of their posters.
 

About Us

"It's about Microsoft Excel"