This can't be the best way to do this
As I was bicycling across town after submitting my answer, it occurred to me
that I'd misread. Thanks, Tom.
Also, "Combobo" in the code below, should read "ComboBox"
Doug
"Tom Ogilvy" wrote in message
...
As I read his code, it would be more like this: (every value in every
column
didn't go in every combobox)
Sub Fill()
Dim Tx As String
Dim rw, col As Long
Dim ctl As Control
For col = 61 To 72
For rw = 25 To 35
With Worksheets("Sheet1").Cells(rw, col)
If .Value < "" Then
controls("Combobo" & col-60).AddItem .Value
End If
End With
Next rw
Next col
End Sub
--
Regards,
Tom Ogilvy
Doug Glancy wrote in message
...
Chris,
I think this boils it down for you:
Sub Fill()
Dim Tx As String
Dim rw, col As Long
Dim ctl As Control
For col = 61 To 72
For rw = 25 To 35
With Worksheets("Sheet1").Cells(rw, col)
If .Value < "" Then
For Each ctl In UserForm1.Controls
If TypeOf ctl Is msforms.ComboBox Then 'assuming
that
you're doing this with all your comboboxes
Tx = .Value
ctl.AddItem Tx
End If
Next ctl
End If
End With
Next rw
Next col
End Sub
hth,
Doug
"Chris A" wrote in message
s.com...
I use a few forms and i'm finding i have to cyle through controls,
i've
given it a go and can't seem to find what i need, this works but
again,
i
have a feeling it's not quite right.
Sub Fill()
Dim Tx As String
Dim rw As Long
For rw = 25 To 35
With Worksheets("Sheet1").Cells(rw, 61)
If .Value = "" Then
Else
Tx = .Value
ComboBox1.AddItem Tx
End If
End With
With Worksheets("Sheet1").Cells(rw, 62)
If .Value = "" Then
Else
Tx = .Value
ComboBox2.AddItem Tx
End If
End With
With Worksheets("Sheet1").Cells(rw, 63)
If .Value = "" Then
Else
Tx = .Value
ComboBox3.AddItem Tx
End If
End With
' <...snip... This repeats quite a bit,
With Worksheets("Sheet1").Cells(rw, 72)
If .Value = "" Then
Else
Tx = .Value
ComboBox12.AddItem Tx
End If
End With
Next rw
End Sub
Thanks for looking
ChrisA
|