View Single Post
  #1   Report Post  
Posted to microsoft.public.excel.programming
ScottMSP ScottMSP is offline
external usenet poster
 
Posts: 34
Default Slow Macro - Delete Row Based on Condition-Modified Ron DeBruin Ma

Hello,

I have modified Ron DeBruin's macro that deletes an entire row based on a
condition. When I test the macro on a small sample (less than 100) it works
quickly (I am deleting any row that does not have "Central Metro" in column
D. When I run it on my full data set (4000 rows), it runs for over 10
minutes but never completes. Ultimately I have forced it to stop.

Is there a way to speed this up and work with the 4000 rows? Is there
another way to program it?

I have pasted the macro below.

Thanks in advance.
-Scott

Sub Loop_Example()
Dim Firstrow As Long
Dim Lastrow As Long
Dim Lrow As Long
Dim CalcMode As Long
Dim ViewMode As Long

With Application
CalcMode = .Calculation
.Calculation = xlCalculationManual
.ScreenUpdating = False
End With

'We use the ActiveSheet but you can replace this with
'Sheets("MySheet")if you want
With ActiveSheet

'We select the sheet so we can change the window view
.Select

'If you are in Page Break Preview Or Page Layout view go
'back to normal view, we do this for speed
ViewMode = ActiveWindow.View
ActiveWindow.View = xlNormalView

'Turn off Page Breaks, we do this for speed
.DisplayPageBreaks = False

'Set the first and last row to loop through
Firstrow = "2"
Lastrow = .UsedRange.Rows(.UsedRange.Rows.Count).Row

'We loop from Lastrow to Firstrow (bottom to top)
For Lrow = Lastrow To Firstrow Step -1

'We check the values in the A column in this example
With .Cells(Lrow, "D")

If Not IsError(.Value) Then

If .Value < "Central Metro" Then .EntireRow.Delete

'This will delete each row with the Value "ron"
'in Column A, case sensitive.

End If

End With

Next Lrow

End With

ActiveWindow.View = ViewMode
With Application
.ScreenUpdating = True
.Calculation = CalcMode
End With

End Sub