Take the quotes off the last line:

Windows(quotenumber1).Activate

With that change it works for me in a regular module.

But I agree with the other posts that suggest a different way to reference
the range, although I don't think that's why you are seeing the error.

--
Tim Zych
SF, CA


"Oldjay" wrote in message
...
I have a workbook open but not active named 123Q and a
Range("Input!ab2") = 123

Private Sub CommandButton2_Click() 'Generates PDF Quote Form

Dim CurrentPrinter As Variant
Dim quotenumber As String
Dim quotenumber1 As String

quotenumber = Range("Input!ab2")
quotenumber1 = quotenumber + "Q" + ".xls"

'Windows("quotenumber1").Activate

Why do i get an error message "subscript out of range"

oldjay