Thread: Slow Macro
View Single Post
  #5   Report Post  
Posted to microsoft.public.excel.programming
JLatham JLatham is offline
external usenet poster
 
Posts: 3,365
Default Slow Macro

I meant to ask that same question - the second replace does appear to undo
all of what the first one did.

" wrote:

On Jun 29, 7:39 am, Dave Peterson wrote:
Sometimes changing calculation to manual, doing the change, then turning
calculation back to automatic can speed things up.

Other times, it doesn't help much.





Frank Situmorang wrote:

Hello,


I found it that my following VBA makes it slow. Could you please help me how
can we make it faster, bacause we will do for huge worksheets and 100 of
workbooks.
Selection.Replace What:="", Replacement:="$$$$$", LookAt:=xlPart, _
SearchOrder:=xlByRows, MatchCase:=False, SearchFormat:=False, _
ReplaceFormat:=False
Selection.Replace What:="$$$$$", Replacement:="", LookAt:=xlPart, _
SearchOrder:=xlByRows, MatchCase:=False, SearchFormat:=False, _
ReplaceFormat:=False


Out of my whole VBA:


Sub frankmodi()
Windows("M10-7-012 MORIC INDONESIA.xls").Activate
Sheets("PO New (2)").Copy After:=Sheets(2)
Cells.Select
Selection.Copy
Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, _
SkipBlanks:=False, Transpose:=False
Columns("A:AV").Select
Application.CutCopyMode = False
Selection.Delete Shift:=xlToLeft
Cells.Select
Selection.Sort Key1:=Range("A1"), Order1:=xlDescending, Header:=xlGuess, _
OrderCustom:=1, MatchCase:=False, Orientation:=xlTopToBottom, _
DataOption1:=xlSortNormal
Selection.Replace What:="", Replacement:="$$$$$", LookAt:=xlPart, _
SearchOrder:=xlByRows, MatchCase:=False, SearchFormat:=False, _
ReplaceFormat:=False
Selection.Replace What:="$$$$$", Replacement:="", LookAt:=xlPart, _
SearchOrder:=xlByRows, MatchCase:=False, SearchFormat:=False, _
ReplaceFormat:=False
End Sub


We appreciate your help.


I thought I posted this reply earlier but it never showed up.

I am curious what the purpose of the 2 replace commands is. Since
they are one after the other, selection hasn't changed and the second
appears to undo the first.

Also, since the first replace command uses an empty string for the
WHAT, won't that result in a large number of replacements?

Peter