View Single Post
  #2   Report Post  
Posted to microsoft.public.excel.programming
Jim Cone Jim Cone is offline
external usenet poster
 
Posts: 3,290
Default Macro loop problem


It looks right but it doesn't act right, because the "rows" property of a range
refers to the rows within the range - not the rows in the worksheet.
Since there is only one row in the range and you specify 10, it is referring
to the single cell 9 rows below - cells(19, 1).
To refer to the entire row of a worksheet, you need (surprise) the
"EntireRow" property.

Furthermore, Excel cannot keep track of the rows if they are deleted
from the top down - you would think the following would work but it skips
every other row...

Sub RowDeletingMacro()
Dim x As Long
x = 10
Do While Cells(x, 1).Value < ""
If Cells(x, 1).Value = 0 Then
Cells(x, 1).EntireRow.Delete Shift:=xlUp
End If
x = x + 1
Loop
End Sub
'--
Row 10 gets deleted, row 11 becomes row ten and the code is looking at
Row 11 - which was row 12 and so on.

You have to find the last row (or specify one) and work up...
For Rw = 99 to 2 Step -1
If Cells(Rw, 1).Value < "" Then
If Cells(Rw, 1).Value = 0 Then
Cells(Rw, 1).EntireRow.Delete
End If
End if
Next
--
Jim Cone
San Francisco, USA
http://www.realezsites.com/bus/primitivesoftware



"Ben"

wrote in message
Hello, I'm very new to writing macros with the Visual Basic editor, so I was
wondering if someone could help me figure out why nothing happens when I run
the following macro:

Sub RowDeletingMacro()
x = 10
Do While Cells(x, 1).Value < ""
If Cells(x, 1).Value = 0 Then
Cells(x, 1).Rows(x).Select
Selection.Delete Shift:=xlUp
End If
x = x + 1
Loop
End Sub
My goal with this macro is to delete all rows in my worksheet that have "0"
as an entry in the first column, and to skip over all of the rows that do not
have 0 as their first column entry. Any help would be greatly appreciated,
thanks very much,
Ben