If you want to concatenate different strings and string-variables, use
the ampersand (&) instead of the plus-sign (+).

Thus:

filesavename = "EFF " & Worksheets(1).Range("E7") & " " & Worksheets
(1).Range("E9") & etc...

HTH, CoRrRan

"correomaster" wrote in
oups.com:

Hi everyone,

I am in the process of creating a spreadsheet (a form to be precise)
where users insert data. The form is then sent to myself for collation.
I am trying to automate the process for the creation of the file name.

I have come up with the following:

filesaveName = "EEF" + " " + Worksheets(1).Range("E7") + " " +
Worksheets(1).Range("E9") + " " + Application.Text(Now(),
"dd-mm-yyyy") + " - " + Application.Text(Now(), "hhmm") + "h" & ".xls"
ActiveWorkbook.SaveAs (ActiveWorkbook.Path & "\" & filesaveName)
ActiveWorkbook.SendMail Recipients:=xxx

Supposedly this would generate a title such as EEF Event Date1 Date2
Time.xls

I have used used a very similar macro in the past that has worked fine.
It didn't contain the "Worksheets(1).Range("X"), which I understands
will read the values of a given cell and make them part of the
filename.

Any suggestions? Thanks in advance

:-)