When your code returns a value it needs to be a Function, not a Sub:
Function TestSub(var1 As Integer) as Integer

TestSub = var1 + 2

End Function

Sub testsub2()
Dim var1

var1 = TestSub(2)
MsgBox var1

End Sub

"Andibevan" wrote:

Hi All,

What do I need to change in order to get the following to work. Should I be
using a function for this sort of routine?

I get the error "expected function or variable"

Sub TestSub(var1 As Integer)

TestSub = var1 + 2

End Sub

Sub testsub2()
Dim var1

var1 = TestSub(2)
MsgBox var1

End Sub