Hi Andrzej

I notice in this post that you have declared szukana as Range
Cecha as String, and Static adres as String

however, you have changed the code I originally posted. I suggest you
delete what you have, and copy and paste the following instead, and only
amend the special characters!

Sub CommandButton3_Click()
Dim szukana As Range
Dim Cecha as String

Cecha = InputBox("Podaj nazwe cechy", "Wprowad warto")
If Cecha = "" Then Exit Sub
Workbooks.Open Filename:= _
"C:\Documents and Settings\J Kasselman\My Documents\p1.xls"
Set szukana = Cells.Find(What:=Cecha, After:=ActiveCell, LookIn:=xlFormulas,
LookAt:= _
xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlNext,
MatchCase:= _
False, SearchFormat:=False)
If szukana Is Nothing Then
MsgBox "Przykro mi, ale" & Cecha & "nie znaleziono"
ActiveWorkbook.Close
Exit Sub
Else
Cells.Find(What:=Cecha, After:=ActiveCell, LookIn:=xlFormulas, LookAt:= _
xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlNext,
MatchCase:= _
False, SearchFormat:=False).Activate
ActiveWorkbook.Close
ActiveCell.Value = Cecha
End If

End Sub

"Andrzej" wrote:

hello everyone,

I have two file. When I work in first file (p2.xls) i need to find something
in second file(p1.xls). Then write in the ActiveCell of p2.xls, provided
that Cecha is found


I have button with code: but Why it doesn't work...

I made mistake ?? where...


Private Sub CommandButton3_Click()
Dim Cecha As String
Dim szukana As Range
Static adres As String

Cecha = InputBox("Podaj nazwe cechy (Enter the name)", "Wprowad¼ warto¶æ
(Enter value)")
If Cecha = "" Then Exit Sub

Workbooks.Open Filename:= _
"H:\Documents and Settings\ANDRZEJ\Pulpit\test\p1.xls"

If adres = "" Then

Set szukana = Cells.Find(What:=Cecha, _
After:=ActiveCell, _
LookIn:=xlValues, _
LookAt:=xlPart, _
SearchOrder:=xlByColumns, _
SearchDirection:=xlNext, _
MatchCase:=False)
Else

Set szukana = Cells.FindNext(ActiveCell)

End If

If Not szukana Is Nothing Then

If szukana.Address < adres Then
szukana.Activate
If adres = "" Then
adres = szukana.Address
End If
Else
MsgBox ("Przeszukiwanie zakoñczone !!(End finding)")
adres = ""
ActiveWorkbook.Close
ActiveCell = Cecha
End If
Else
adres = ""
MsgBox ("Przykro mi, ale (Sorry, but) " & Cecha & " nie znaleziono (was
not found)")
ActiveWorkbook.Close

End If

End Sub


and second version (it doesn't work also )


Private Sub CommandButton1_Click()

Dim Cecha As String
Dim szukana As Range
Static adres As String

Cecha = InputBox("Podaj nazwe cechy (Enter the name)", "Wprowad¼ warto¶æ
(Enter value)")
If Cecha = "" Then Exit Sub

Workbooks.Open Filename:= _
"H:\Documents and Settings\ANDRZEJ\Pulpit\test\p1.xls"
Dim notthere As Range
Set notthere = Cells.Find(What:=Cecha, After:=ActiveCell,
LookIn:=xlFormulas, LookAt:= _
xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlNext, MatchCase:= _
False, SearchFormat:=False)
If notthere Is Nothing Then
MsgBox ("Przykro mi, ale (Sorry, but) " & Cecha & " nie znaleziono
(was not found)")
ActiveWorkbook.Close
Exit Sub
Else
Cells.Find(What:=Cecha, After:=ActiveCell, LookIn:=xlFormulas, LookAt:=
_
xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlNext, MatchCase:= _
False, SearchFormat:=False).Activate
ActiveWorkbook.Close
ActiveCell.Formula = Cecha
End If

End Sub


Andrzej, Student from Poland