LinkBack Thread Tools Search this Thread Display Modes
Prev Previous Post   Next Post Next
  #1   Report Post  
Posted to microsoft.public.excel.programming
external usenet poster
 
Posts: 5
Default Code Improvements

Hi all.
I need a way to improve the code shown below.
The code first checks if time in column P is between the namedranges
ShipmentDate_StartValue & ShipmentDate_EndValue, marks the row del or keep.
Then loops back through this and deletes cols A through Q if marked del.

Sheet3.Activate
Range("Q2").Select
' Removes extra rows not within start & end range
Do While Not IsEmpty(ActiveCell.Offset(0, -1))
ActiveCell.FormulaR1C1 = _
"=IF(OR('Dollies -
Shipment'!RC[-1]<ShipmentDate_StartValue,'Dollies -
Shipment'!RC[-1]ShipmentDate_EndValue),""Del"",""Keep"")"
ActiveCell.Offset(1, 0).Select
Loop
Range("Q2").Select
Do While Not IsEmpty(ActiveCell.Offset(0, -1))
Do While ActiveCell = "Del"
ActiveCell.Offset(0, -16).Range("A1:Q1").Select
Selection.Delete Shift:=xlUp
ActiveCell.Offset(0, 16).Select
Loop
ActiveCell.Offset(1, 0).Select
Loop
ActiveSheet.Range("Q:Q").ClearContents


When I run this using Excel 2003 the code takes approx. 8/9 seconds.
When using Excel 2010 the code runs for nearly 2 minutes.
I cannot see any reason for this delay.

Is there a more efficient way of coding the above.
Our company has now upgraded to Excel 2007 which is the reason for the
change.
Thanks in advance,
edul
 
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules

Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
Improvements to code Brad Excel Programming 2 May 21st 09 05:16 PM
Improvements to code Brad Excel Programming 1 November 25th 08 04:23 PM
Code Improvements Larry Excel Programming 6 September 26th 06 07:29 PM
Message Box Improvements Phil Hageman[_4_] Excel Programming 3 June 17th 05 05:34 PM
ListView to Excel Code (but needs SPEED improvements) SVD Excel Programming 1 February 2nd 04 10:54 AM


All times are GMT +1. The time now is 04:13 AM.

Powered by vBulletin® Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Copyright ©2004-2024 ExcelBanter.
The comments are property of their posters.
 

About Us

"It's about Microsoft Excel"