ExcelBanter

ExcelBanter (https://www.excelbanter.com/)
-   Excel Programming (https://www.excelbanter.com/excel-programming/)
-   -   What wrong with the coding? (https://www.excelbanter.com/excel-programming/441797-what-wrong-coding.html)

Eric

What wrong with the coding?
 
Does anyone have any suggestions on what wrong is the coding?
If specific cell contains the text "ON", then keep processing the coding,
else skip it and next.
Does anyone have any suggestions on how to fix the coding at Error line?
Thanks in advance for any suggestions
Eric

Sub aUpdating()

Dim lngRow As Long, ws As Worksheet, wsDate As Worksheet

Set wsDate = Sheets("Date")
For lngRow = 2 To wsDate.Range("E1").Value

If wsDate.Range("F" & IngRow).Value = "ON" Then ' Error on this line

'Do something

End If
Next

End Sub

Chip Pearson

What wrong with the coding?
 
You have declare a variable named "lngRow" (starts with a lower case
"L") and you are using in your conditional "IngRow" (starts with an
upper case "I").

Cordially,
Chip Pearson
Microsoft Most Valuable Professional,
Excel, 1998 - 2010
Pearson Software Consulting, LLC
www.cpearson.com



On Mon, 19 Apr 2010 09:31:01 -0700, Eric
wrote:

Sub aUpdating()

Dim lngRow As Long, ws As Worksheet, wsDate As Worksheet

Set wsDate = Sheets("Date")
For lngRow = 2 To wsDate.Range("E1").Value

If wsDate.Range("F" & IngRow).Value = "ON" Then ' Error on this line

'Do something

End If
Next


Joe User[_2_]

What wrong with the coding?
 
"Chip Pearson" wrote:
You have declare a variable named "lngRow"
(starts with a lower case "L") and you are
using in your conditional "IngRow" (starts
with an upper case "I").


Mistakes like that can be avoided by putting the statement Option Explicit
at the start of the module. It requires that all variables be declared
explicitly.


----- original message -----

"Chip Pearson" wrote in message
...
You have declare a variable named "lngRow" (starts with a lower case
"L") and you are using in your conditional "IngRow" (starts with an
upper case "I").

Cordially,
Chip Pearson
Microsoft Most Valuable Professional,
Excel, 1998 - 2010
Pearson Software Consulting, LLC
www.cpearson.com



On Mon, 19 Apr 2010 09:31:01 -0700, Eric
wrote:

Sub aUpdating()

Dim lngRow As Long, ws As Worksheet, wsDate As Worksheet

Set wsDate = Sheets("Date")
For lngRow = 2 To wsDate.Range("E1").Value

If wsDate.Range("F" & IngRow).Value = "ON" Then ' Error on this line

'Do something

End If
Next



Barb Reinhardt

What wrong with the coding?
 
Add OPTION EXPLICIT before your sub and try to compile the code. You'll see
where the problem is.
--
HTH,

Barb Reinhardt



"Eric" wrote:

Does anyone have any suggestions on what wrong is the coding?
If specific cell contains the text "ON", then keep processing the coding,
else skip it and next.
Does anyone have any suggestions on how to fix the coding at Error line?
Thanks in advance for any suggestions
Eric

Sub aUpdating()

Dim lngRow As Long, ws As Worksheet, wsDate As Worksheet

Set wsDate = Sheets("Date")
For lngRow = 2 To wsDate.Range("E1").Value

If wsDate.Range("F" & IngRow).Value = "ON" Then ' Error on this line

'Do something

End If
Next

End Sub


Rick Rothstein

What wrong with the coding?
 
And then, after you do as Barb has suggested and you see the benefit of
using Option Explicit, click Tools/Options on the VB Editor's menu bar,
select the Editor tab on the dialog box that appears and put a check mark in
the CheckBox labeled "Require Variable Declaration"... doing that will
automatically place the Option Explicit statement in all **new** code
windows that get called up (not only in your current project, but in all
projects you work on afterwards). Note, I said "new" windows... the Option
Explicit statement will not be added to any existing windows with code in
them, only to new window called up after the option is evoked. Oh, and I
would also suggest you uncheck the CheckBox labeled "Auto Syntax Check" if
you haven't already done so. Incorrect syntax will still be highlighted for
you, but you won't be bothered by dialog boxes insisting you fix the code
line right then and there.

--
Rick (MVP - Excel)



"Barb Reinhardt" wrote in message
...
Add OPTION EXPLICIT before your sub and try to compile the code. You'll
see
where the problem is.
--
HTH,

Barb Reinhardt



"Eric" wrote:

Does anyone have any suggestions on what wrong is the coding?
If specific cell contains the text "ON", then keep processing the coding,
else skip it and next.
Does anyone have any suggestions on how to fix the coding at Error line?
Thanks in advance for any suggestions
Eric

Sub aUpdating()

Dim lngRow As Long, ws As Worksheet, wsDate As Worksheet

Set wsDate = Sheets("Date")
For lngRow = 2 To wsDate.Range("E1").Value

If wsDate.Range("F" & IngRow).Value = "ON" Then ' Error on this line

'Do something

End If
Next

End Sub




All times are GMT +1. The time now is 11:34 AM.

Powered by vBulletin® Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
ExcelBanter.com