Reply
 
LinkBack Thread Tools Search this Thread Display Modes
  #1   Report Post  
Posted to microsoft.public.excel.programming
external usenet poster
 
Posts: 16
Default Loop without Do


My problem is that I get a "Loop without Do" statement (my code might have
other problems....I'll get to them later !)

No need to tell ya guys I'm a newbie...
Thanks in advance
Marc

Here's my code:


Sub NoComact()

Dim counter As Integer
Dim compteur As Integer
counter = 1
compteur = 1

Do
While counter < 1000
Do
Range("B, counter").Select
While Right("B, counter", 1) < Right("B, counter + 1", 1)
Range("C, counter").Value = "BRG-000 & compteur "
counter = counter + 1
Loop
compteur = compteur + 1
Loop
End Sub

(btw, compteur is counter in french)
  #2   Report Post  
Posted to microsoft.public.excel.programming
external usenet poster
 
Posts: 11,501
Default Loop without Do

Hi,

because your enclosing your variable in quotes they're not being treated as
variable. Here's the corrected syntax for the middle loop but it is
fundamentally flawed because as soon as the code finds a value where (say) B2
is < B1 it will go into an endless loop, it will thenterminate quite quickly
with OVERFLOW because your variables are declared as integers and should be
long. Perhaps you could explain what it is your trying to do

Do While Right(Range("B" & counter), 1) < Right(Range("B" & counter + 1), 1)
Range("C" & counter).Value = "BRG-000" & compteur
counter = counter + 1
Loop

Mike

"Marc Gendron" wrote:


My problem is that I get a "Loop without Do" statement (my code might have
other problems....I'll get to them later !)

No need to tell ya guys I'm a newbie...
Thanks in advance
Marc

Here's my code:


Sub NoComact()

Dim counter As Integer
Dim compteur As Integer
counter = 1
compteur = 1

Do
While counter < 1000
Do
Range("B, counter").Select
While Right("B, counter", 1) < Right("B, counter + 1", 1)
Range("C, counter").Value = "BRG-000 & compteur "
counter = counter + 1
Loop
compteur = compteur + 1
Loop
End Sub

(btw, compteur is counter in french)

  #3   Report Post  
Posted to microsoft.public.excel.programming
external usenet poster
 
Posts: 131
Default Loop without Do

It is a little difficult to be sure what you're trying to do. However, I
think the following may get fairly close. You may need to tweak a bit, but
this will give you some new ideas anyhow.

Specific notes: 1) You don't need to "select" a cell to perform operations
with it; and 2) you can use a "do while" loop, but it should be a single
statement (i.e. on one line) with the "while" condition stated on the same
line. If your line is too long, you can wrap it using
[space][underscore][enter].

Sub OtherWaysToLoop()

Dim i As Long, r As Long
Application.ScreenUpdating = False

i = 1
For r = 1 To 999
If Right(Cells(r, 2), 1) < Right(Cells(r + 1, 2), 1) Then
Cells(r, 3) = "BRG-000" & i
Else
i = i + 1
Cells(r, 3) = "BRG-000" & i
End If
Next

End Sub

"Marc Gendron" wrote:


My problem is that I get a "Loop without Do" statement (my code might have
other problems....I'll get to them later !)

No need to tell ya guys I'm a newbie...
Thanks in advance
Marc

Here's my code:


Sub NoComact()

Dim counter As Integer
Dim compteur As Integer
counter = 1
compteur = 1

Do
While counter < 1000
Do
Range("B, counter").Select
While Right("B, counter", 1) < Right("B, counter + 1", 1)
Range("C, counter").Value = "BRG-000 & compteur "
counter = counter + 1
Loop
compteur = compteur + 1
Loop
End Sub

(btw, compteur is counter in french)

Reply
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules

Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
returning back to loop check condition without completing the loop ashish128 Excel Programming 13 April 3rd 08 12:53 PM
Loop to Filter, Name Sheets. If Blank, Exit Loop ryguy7272 Excel Programming 3 February 5th 08 03:41 PM
Naming Worksheets - Loop within a loop issue klysell Excel Programming 5 March 29th 07 05:48 AM
Naming Worksheets - Loop within a loop issue klysell Excel Programming 0 March 27th 07 11:17 PM
Advancing outer Loop Based on criteria of inner loop ExcelMonkey Excel Programming 1 August 15th 05 05:23 PM


All times are GMT +1. The time now is 11:16 AM.

Powered by vBulletin® Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Copyright ©2004-2025 ExcelBanter.
The comments are property of their posters.
 

About Us

"It's about Microsoft Excel"