LinkBack Thread Tools Search this Thread Display Modes
Prev Previous Post   Next Post Next
  #1   Report Post  
Posted to microsoft.public.excel.programming
external usenet poster
 
Posts: 8
Default Could someone review my first Excel VBA program?

Hi everyone.This is my first attempt at coding in VBA for Excel. If
someone could give any tips about my code, I'd really appreciate it.

In a nutshell, this code reads a source spreadsheet of about 35,000
rows and pulls each sales manager out into a template file which
contains a pivot table. The template is then saved as a spreadsheet
with that manager's name. The code works, but I'm sure there's
something that can be improved. I thought it might be less memory
intensive if I could copy over an entire row into the template sheet.
But every time I tried writing code for that, I kept getting errors
preventing it from running. Thanks.

Dim varSourceRow As Integer 'Defines which row to read data from
source file
Dim varTemplateRow As Integer 'Defines which row to write data in
template file
Dim currentMgr As String 'Defines which manager is currently
being read
Dim pivotRange As String 'Defines data range for Pivot Table
in template
Dim varSourceLen As Integer 'Defines row count of the source
file



'Turn off screen updates
Application.ScreenUpdating = False

'Load the source data and template data into memory
Set sourceWB = Workbooks.Open("C:\Documents and Settings\Test
\Desktop\ReportTest\Source.xls", True, True)
Set templateWB = Workbooks.Open("C:\Documents and Settings\Test
\Desktop\ReportTest\Template.xls", True, True)

'Sets sales manager for first loop
currentMgr = sourceWB.Worksheets("Source Data").Cells(2, 3)
varTemplateRow = 2
varIteraion = 2
varSourceLen = sourceWB.Worksheets("Source
Data").UsedRange.Rows.Count


For r = 2 To varSourceLen

'If the row in the source document has the current sales manager
If sourceWB.Worksheets("Source Data").Cells(varSourceRow, 3).Value
= currentMgr Then
For clNumber = 1 To 16

'For each column copy over the cell data to the template file
templateWB.Worksheets("Sheet1").Cells(varTemplateR ow,
clNumber).Value = sourceWB.Worksheets("Source
Data").Cells(varSourceRow, clNumber).Value
Next clNumber
varTemplateRow = varTemplateRow + 1
intCount = intCount + 1

'If the row in the source document does not have the current sales
manger
Else
'Define the pivot table range
pivotRange = "Sheet1!R1C1:R" & varTemplateRow - 1 & "C16"

'Refresh the pivot table with the new data

templateWB.Worksheets("Pivot").PivotTables("PivotT emp").ChangePivotCache
templateWB.PivotCaches.Create(SourceType:=xlDataba se,
SourceData:=pivotRange)

templateWB.Worksheets("Pivot").PivotTables("PivotT emp").RefreshTable

'Save the file using the sales manager name
templateWB.SaveAs "C:\Documents and Settings\Test\Desktop
\ReportTest\" & currentMgr & ".xls", FileFormat:=56
currentMgr = rawWb.Worksheets("Source
Data").Cells(varSourceRow, 3).Value

'Clear the contents of the template file for the next cycle
and reset the template row count
pivotRange = "A2:P" & varTemplateRow

templateWB.Worksheets("Sheet1").Range(pivotRange). ClearContents
varTemplateRow = 2
End If
Next rwNumber

'Once complete close the original files and remove variable values
sourceWB.Close False
templateWB.Close False
Set rawWb = Nothing
Set templateWB = Nothing
Application.ScreenUpdating = True
 
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules

Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
Is there a way to unload the loaded XLL file in Excel? Hi all, I amdebugging XLL link library using Visual C++. Everytime I rebuild the XLL, Ihave to close the whole Excel program and relaunch the Excel program again,and then load in the newly gene LunaMoon Excel Discussion (Misc queries) 0 July 28th 08 11:03 PM
From Access to Excel Question - VBA review Filo Excel Programming 1 June 14th 07 10:20 PM
excel review bar broke Excel Discussion (Misc queries) 2 May 5th 05 04:46 PM
VB6 with Excel Objects: Please review my code Kurt Remlin Excel Programming 6 May 1st 04 03:36 AM


All times are GMT +1. The time now is 09:55 PM.

Powered by vBulletin® Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Copyright ©2004-2025 ExcelBanter.
The comments are property of their posters.
 

About Us

"It's about Microsoft Excel"