Home |
Search |
Today's Posts |
|
#1
Posted to microsoft.public.excel.programming
|
|||
|
|||
Macro not running anymore
Hi,
I use the following macro and it used to run fine - until yesterday. Then, I had to manually stop it (using the windows task manager). Now, t's not working anymore. Well, it seems as if it's still working, but the output file is not created. Any ideas about the problem? Thanks, Andreas Sub test() ListCombos Range("A1:A5"), 3, "Output.csv" End Sub Sub ListCombos(r As Range, ByVal m As Long, sFile As String) ' lists the combinations of r choose m to file sFile ' r is a single-column or single-row range Dim ai() As Long Dim i As Long Dim n As Long Dim sOut As String Dim iFF As Integer If r Is Nothing Then Exit Sub If r.Rows.Count < 1 And r.Columns.Count < 1 Then Exit Sub n = r.Count If m < 1 Then Exit Sub If m n Then m = n iFF = FreeFile Open sFile For Output As #iFF Redim ai(1 To m) ai(1) = 0 For i = 2 To m ai(i) = i Next i Do For i = 1 To m - 1 If ai(i) + 1 < ai(i + 1) Then ai(i) = ai(i) + 1 Exit For Else ai(i) = i End If Next i If i = m Then If ai(m) < n Then ai(m) = ai(m) + 1 Else Exit Do End If End If ' catenate and write to file sOut = vbNullString For i = 1 To m sOut = sOut & r(ai(i)).Text & "," Next i Write #iFF, Left(sOut, Len(sOut) - 1) Loop Close #iFF End Sub |
#2
Posted to microsoft.public.excel.programming
|
|||
|
|||
Macro not running anymore
hi Andreas,
maybe you´re searching the output.csv in the wrong directory? If you use file/open to open a file in Excel and start the macro, output.csv will be saved in the directory of file/open-dialog and not in the directory of the file with the macro. therefore add a path to your macro, eg ListCombos Range("A1:A5"), 3, thisworkbook.path & "\Output.csv" bye stefan On 22 Mai, 16:29, Andreas wrote: Hi, I use the following macro and it used to run fine - until yesterday. Then, I had to manually stop it (using the windows task manager). Now, t's not working anymore. Well, it seems as if it's still working, but the output file is not created. Any ideas about the problem? Thanks, Andreas Sub test() * * ListCombos *Range("A1:A5"), 3, "Output.csv" End Sub Sub ListCombos(r As Range, ByVal m As Long, sFile As String) * * *' lists the combinations of r choose m to file sFile * * *' r is a single-column or single-row range * * Dim *ai() * *As Long * * Dim i * * * As Long * * Dim n * * * As Long * * Dim sOut * *As String * * Dim iFF * * As Integer * * If r Is Nothing Then Exit Sub * * If r.Rows.Count < 1 And r.Columns.Count < 1 Then Exit Sub * * n = r.Count * * If m < 1 Then Exit Sub * * If m n Then m = n * * iFF = FreeFile * * Open sFile For Output As #iFF * * Redim ai(1 To m) * * ai(1) = 0 * * For i = 2 To m * * * * ai(i) = i * * Next i * * Do * * * * For i = 1 To m - 1 * * * * * * If ai(i) + 1 < ai(i + 1) Then * * * * * * * * ai(i) = ai(i) + 1 * * * * * * * * Exit For * * * * * * Else * * * * * * * * ai(i) = i * * * * * * End If * * * * Next i * * * * If i = m Then * * * * * * If ai(m) < n Then * * * * * * * * ai(m) = ai(m) + 1 * * * * * * Else * * * * * * * * Exit Do * * * * * * End If * * * * End If * * * * *' catenate and write to file * * * * sOut = vbNullString * * * * For i = 1 To m * * * * * * sOut = sOut & r(ai(i)).Text & "," * * * * Next i * * * * Write #iFF, Left(sOut, Len(sOut) - 1) * * *Loop * * Close #iFF End Sub |
#3
Posted to microsoft.public.excel.programming
|
|||
|
|||
Macro not running anymore
Thanks, Stefan.
Unfortunately, it's still not working. It's strange because it worked before, saving the output file in the directory where I saved the excel file. I wonder if I crashed my Excel program when stopping the macro using the task manager? Andreas |
#4
Posted to microsoft.public.excel.programming
|
|||
|
|||
Macro not running anymore
hi Andreas,
i can´t believe that the task manager somehow influenced your macro or file. you could use Textboxes or Debug.print in your code to check if it`s running. Did you check the code adding a path and forgot to insert the \ before output.csv ? bye stefan On 22 Mai, 17:02, wrote: Thanks,Stefan. Unfortunately, it's still not working. It's strange because it worked before, saving the output file in the directory where I saved the excel file. I wonder if I crashed my Excel program when stopping the macro using the task manager? Andreas |
Reply |
Thread Tools | Search this Thread |
Display Modes | |
|
|
Similar Threads | ||||
Thread | Forum | |||
Report with macro losing links to a particular worksheet after running macro | Excel Programming | |||
disable user running macro from Tools Macro | Excel Discussion (Misc queries) | |||
Need syntax for RUNning a Word macro with an argument, called from an Excel macro | Excel Programming | |||
Macro doesn´t work anymore | Excel Programming | |||
Macro closes excel and therefore won't run anymore | Excel Programming |