LinkBack Thread Tools Search this Thread Display Modes
Prev Previous Post   Next Post Next
  #1   Report Post  
Posted to microsoft.public.excel.programming
external usenet poster
 
Posts: 12
Default Help - Loop Function Giving Incorrect Output

I need help with this loop that I created, but is giving me the wrong
results...what am I doing wrong?? Any help would be greatly
appreciated!!!


A B C D E F G H I J
1
2
3 Date: 1 2 3 4 5 6 7 8
4 UNIT1 G(00:00) R X X X X R R X
5 D(08:00) R X X X X R R R
6 S(16:00) X X X X X R R X

The R's above indicate operating hours for a production unit. I
created a function that needs to take the above excel data and write
a CSV file that records when the unit is scheduled to be up.

The format would be:


UNIT NAME, PRODUCT, START TIME, END TIME

In this case, R is equal to product ROHS. So for the example above,
my
output CSV would be as follows:

UNIT1, ROHS, 04/01/2008 00:00, 04/01/2008 16:00
UNIT1, ROHS, 04/06/2008 00:00, 04/08/2008 00:00
UNIT1, ROHS, 04/08/2008 08:00, 04/08/2008 16:00

But my code is creating an output file of the following:

UNIT1,rohs,04/01/2008 08:00,04/01/2008 16:00
UNIT1,rohs,04/07/2008 16:00,04/08/2008 00:00
UNIT1,rohs,04/08/2008 08:00,04/08/2008 16:00



This is my code:


Sub ProcessRanges()

'This is the main procedure that processes all turns and writes them
into an output file


On Error GoTo ExitSub
Dim StartingDateRange As Range, FileName As String
Dim FileNumber As Integer
Dim Unit As Integer
Dim PreviousShiftStatus As String
Dim Rowcount As Integer
Dim LastRow As Integer
Dim sht As Integer



Debug.Print ThisWorkbook.Path
FileName = "C:\FCDM.dat"


FileNumber = FreeFile()
Open FileName For Output As #FileNumber


LastRow = Sheet1.Range("C" & Rows.Count).End(xlUp).Row
Rowcount = 0

Do While Rowcount <= LastRow

'Go through the first sheet for each unit, then move on. Explicit
statement of PreviousShiftStatus = "D"
'because it must start on an UP TURN

Set StartingDateRange = Sheet1.Range("C" & (Rowcount + 3))

PreviousShiftStatus = "D"

For sht = 1 To 1

If CreateCVS(Sheets("sheet" & sht), StartingDateRange,
FileNumber, PreviousShiftStatus) Then

'all is well
Debug.Print "Success..."
Else
'problem
Debug.Print "Failure..."
End If


Next sht

Rowcount = Rowcount + 7

Loop


ExitSub:
Close #FileNumber


End Sub




Private Function CreateCVS( _
sh As Worksheet, _
StartingDateRange As Range, _
FileNumber As Integer, _
PreviousShiftStatus As String) As Boolean


On Error GoTo Err_CreateCVS
Dim UnitNumber As String, CurrentDate As Date, PreviousDate As
Date
Dim DataRange As Range


Dim FirstColumn As Integer, LastColumn As Integer, _
CurrentColumn As Integer


Dim ShiftRow As Long, ShiftStatus(1 To 3) As String
Dim ShiftItem As Integer
Dim OldShiftItem As Integer



Dim CurrentShiftStatus As String
Dim ConservationShutdown As Boolean
Dim HalfDay As Boolean


Dim i As Integer


'Data Range starts with first schedule box. Everything else is
'offset according to this cell


Set DataRange = sh.Range(StartingDateRange.Offset(1), _
StartingDateRange.End(xlToRight).Offset(3))


Debug.Print DataRange(1).Address


FirstColumn = DataRange(1).Column
LastColumn = FirstColumn + DataRange.Columns.Count - 1
ShiftRow = DataRange(1).Row
UnitNumber = DataRange(1).Offset(, -2)
CurrentDate = DateValue(StartingDateRange)


If UnitNumber < "0" Then

For CurrentColumn = FirstColumn To LastColumn

ShiftStatus(1) = sh.Cells(ShiftRow, CurrentColumn)
ShiftStatus(2) = sh.Cells(ShiftRow + 1, CurrentColumn)
ShiftStatus(3) = sh.Cells(ShiftRow + 2, CurrentColumn)


For ShiftItem = 1 To 3




Select Case Trim(UCase(ShiftStatus(ShiftItem)))
Case "R"
CurrentShiftStatus = "rohs"
PreviousDate = DateValue(CurrentDate)
OldShiftItem = ShiftItem

Case " ", "H", "X", ""
CurrentShiftStatus = "D"


End Select


If PreviousShiftStatus < CurrentShiftStatus Then


If PreviousShiftStatus = "rohs" Then



Print #FileNumber, UnitNumber & "," &
PreviousShiftStatus & "," & _
Format(PreviousDate +
Choose(OldShiftItem, #12:00:00 AM#, #8:00:00 AM#, #4:00:00 PM#), _
"mm/dd/yyyy hh:mm") & "," & _
Format(CurrentDate +
Choose(ShiftItem, #12:00:00 AM#, #8:00:00 AM#, #4:00:00 PM#), _
"mm/dd/yyyy hh:mm")

End If





End If

PreviousShiftStatus = CurrentShiftStatus

Next



CurrentDate = CurrentDate + 1
Next
CreateCVS = True
Exit Function
End If

Err_CreateCVS:

End Function




I could really use some direction as to why this is not working for
me!! Thank you so much for whoever can help me debug this
problem....it would allow me to enjoy my weekend!! Thanks!!
 
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules

Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
Nested Formula Giving Incorrect Answer William McCann Excel Discussion (Misc queries) 4 December 1st 09 01:12 PM
Another SUMPRODUCT giving the incorrect number Richard Excel Discussion (Misc queries) 11 June 22nd 07 03:50 PM
SUMPRODUCT is giving incorrect number Richard Excel Discussion (Misc queries) 2 June 22nd 07 11:17 AM
Very large workbook now giving incorrect results :( [email protected] Excel Discussion (Misc queries) 0 July 17th 06 11:29 PM
Formula giving incorrect answer... Jambruins Excel Discussion (Misc queries) 3 February 25th 05 06:59 PM


All times are GMT +1. The time now is 02:24 PM.

Powered by vBulletin® Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Copyright ©2004-2025 ExcelBanter.
The comments are property of their posters.
 

About Us

"It's about Microsoft Excel"