ExcelBanter

ExcelBanter (https://www.excelbanter.com/)
-   Excel Programming (https://www.excelbanter.com/excel-programming/)
-   -   subscript out of range (help) (https://www.excelbanter.com/excel-programming/400353-subscript-out-range-help.html)

edluver

subscript out of range (help)
 
I am trying to simplify some code i use at work by using array's. This is
just a sample or test code that i put together. I keep getting a "subscript
out of range" error inside the first For Next loop. It will display the
inputbox asking for the first name, but once that is entered, i get the
error. what am i doing wrong?

Dim asi19Names() As String
Dim NoofPeople As Integer, _
i As Long

NoofPeople = InputBox(Prompt:="How many people working reports today",
Title:="How Many")

Range("A1").Select
Selection.Value = NoofPeople

For i = 0 To NoofPeople - 1
asi19Names(i) = InputBox(Prompt:="First name of worker"
Title:="Employee's")
Next i

Range("B1").Select

For i = 0 To NoofPeople - 1
Selection.Value = asi19Names(i)
Cells(1, 0).Select
Next i

End Sub


Dave Peterson

subscript out of range (help)
 
You never gave any dimensions to that array.

Still with no validation...

Dim asi19Names() As String
Dim NoofPeople As Integer, _
i As Long


NoofPeople = InputBox(Prompt:="How many people working reports today", _
Title:="How Many")

redim asil9names(0 to noofpeople - 1)

.....

======
Although, it would make more sense to me to use counting numbers:

redim asil9names(1 to noofpeople)

....

For i = lbound(noofpeople) To ubound(noofpeople)
...

edluver wrote:

I am trying to simplify some code i use at work by using array's. This is
just a sample or test code that i put together. I keep getting a "subscript
out of range" error inside the first For Next loop. It will display the
inputbox asking for the first name, but once that is entered, i get the
error. what am i doing wrong?

Dim asi19Names() As String
Dim NoofPeople As Integer, _
i As Long

NoofPeople = InputBox(Prompt:="How many people working reports today",
Title:="How Many")

Range("A1").Select
Selection.Value = NoofPeople

For i = 0 To NoofPeople - 1
asi19Names(i) = InputBox(Prompt:="First name of worker"
Title:="Employee's")
Next i

Range("B1").Select

For i = 0 To NoofPeople - 1
Selection.Value = asi19Names(i)
Cells(1, 0).Select
Next i

End Sub


--

Dave Peterson

INTP56

subscript out of range (help)
 
As posted, you didn't dimension the string

"edluver" wrote:

I am trying to simplify some code i use at work by using array's. This is
just a sample or test code that i put together. I keep getting a "subscript
out of range" error inside the first For Next loop. It will display the
inputbox asking for the first name, but once that is entered, i get the
error. what am i doing wrong?

Dim asi19Names() As String
Dim NoofPeople As Integer, _
i As Long

NoofPeople = InputBox(Prompt:="How many people working reports today",
Title:="How Many")

Range("A1").Select
Selection.Value = NoofPeople

For i = 0 To NoofPeople - 1
asi19Names(i) = InputBox(Prompt:="First name of worker"
Title:="Employee's")
Next i

Range("B1").Select

For i = 0 To NoofPeople - 1
Selection.Value = asi19Names(i)
Cells(1, 0).Select
Next i

End Sub



All times are GMT +1. The time now is 10:05 AM.

Powered by vBulletin® Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
ExcelBanter.com