ExcelBanter

ExcelBanter (https://www.excelbanter.com/)
-   Excel Programming (https://www.excelbanter.com/excel-programming/)
-   -   Closing a file (https://www.excelbanter.com/excel-programming/390732-closing-file.html)

Gert-Jan[_2_]

Closing a file
 
Hi,

I am using this for importing some sheets from a workbook. After importing
the file must be closed.

Sub importerendb()
Range("rekenvel!E2").Value = Range("rekenvel!b13").Value & "\" &
importeren.databasescombo.Value & ".xls"
Dim bestandsnaam
bestandsnaam = Range("rekenvel!E2").Value
Workbooks.Open Filename:=bestandsnaam, Password:="XYZ"
For Each n In ActiveWorkbook.Names
n.Delete
Next
Sheets(Array("lijstkerken", "database")).Move Befo=Workbooks( _
"myfile.xls").Sheets(1)
Workbooks(bestandsnaam).Close savechanges:=False
Unload importeren
End Sub

It goes wrong in the line "Workbooks(bestandsnaam).Close savechanges:=False"

What am I doing wrong?

Thanks for help, Gert-Jan


Bob Umlas

Closing a file
 
Change
Workbooks(bestandsnaam).Close savechanges:=False
to
Workbooks(DIR(bestandsnaam)).Close savechanges:=False
to strip the path -- workbooks(name with path).Close doesn't work. need name
without path


"Gert-Jan" wrote in message
...
Hi,

I am using this for importing some sheets from a workbook. After importing
the file must be closed.

Sub importerendb()
Range("rekenvel!E2").Value = Range("rekenvel!b13").Value & "\" &
importeren.databasescombo.Value & ".xls"
Dim bestandsnaam
bestandsnaam = Range("rekenvel!E2").Value
Workbooks.Open Filename:=bestandsnaam, Password:="XYZ"
For Each n In ActiveWorkbook.Names
n.Delete
Next
Sheets(Array("lijstkerken", "database")).Move Befo=Workbooks( _
"myfile.xls").Sheets(1)
Workbooks(bestandsnaam).Close savechanges:=False
Unload importeren
End Sub

It goes wrong in the line "Workbooks(bestandsnaam).Close
savechanges:=False"

What am I doing wrong?

Thanks for help, Gert-Jan




Tom Ogilvy

Closing a file
 
Sub importerendb()
Dim bk as Workbook
Dim bestandsnaam as String
Range("rekenvel!E2").Value = Range("rekenvel!b13").Value _
& "\" & importeren.databasescombo.Value & ".xls"
bestandsnaam = Range("rekenvel!E2").Value
set bk = Workbooks.Open( _
Filename:=bestandsnaam, Password:="XYZ")
For Each n In bk.Names
n.Delete
Next
Sheets(Array("lijstkerken", "database")).Move Befo=Workbooks( _
"myfile.xls").Sheets(1)
bk.Close savechanges:=False
Unload importeren
End Sub

--
Regards,
Tom Ogilvy


"Gert-Jan" wrote:

Hi,

I am using this for importing some sheets from a workbook. After importing
the file must be closed.

Sub importerendb()
Range("rekenvel!E2").Value = Range("rekenvel!b13").Value & "\" &
importeren.databasescombo.Value & ".xls"
Dim bestandsnaam
bestandsnaam = Range("rekenvel!E2").Value
Workbooks.Open Filename:=bestandsnaam, Password:="XYZ"
For Each n In ActiveWorkbook.Names
n.Delete
Next
Sheets(Array("lijstkerken", "database")).Move Befo=Workbooks( _
"myfile.xls").Sheets(1)
Workbooks(bestandsnaam).Close savechanges:=False
Unload importeren
End Sub

It goes wrong in the line "Workbooks(bestandsnaam).Close savechanges:=False"

What am I doing wrong?

Thanks for help, Gert-Jan



Gert-Jan[_2_]

Closing a file
 
Thanks Tom, but there is an error in:

set bk = Workbooks.Open( _
Filename:=bestandsnaam, Password:="XYZ")



"Tom Ogilvy" schreef in bericht
...
Sub importerendb()
Dim bk as Workbook
Dim bestandsnaam as String
Range("rekenvel!E2").Value = Range("rekenvel!b13").Value _
& "\" & importeren.databasescombo.Value & ".xls"
bestandsnaam = Range("rekenvel!E2").Value
set bk = Workbooks.Open( _
Filename:=bestandsnaam, Password:="XYZ")
For Each n In bk.Names
n.Delete
Next
Sheets(Array("lijstkerken", "database")).Move Befo=Workbooks( _
"myfile.xls").Sheets(1)
bk.Close savechanges:=False
Unload importeren
End Sub

--
Regards,
Tom Ogilvy


"Gert-Jan" wrote:

Hi,

I am using this for importing some sheets from a workbook. After
importing
the file must be closed.

Sub importerendb()
Range("rekenvel!E2").Value = Range("rekenvel!b13").Value & "\" &
importeren.databasescombo.Value & ".xls"
Dim bestandsnaam
bestandsnaam = Range("rekenvel!E2").Value
Workbooks.Open Filename:=bestandsnaam, Password:="XYZ"
For Each n In ActiveWorkbook.Names
n.Delete
Next
Sheets(Array("lijstkerken", "database")).Move Befo=Workbooks( _
"myfile.xls").Sheets(1)
Workbooks(bestandsnaam).Close savechanges:=False
Unload importeren
End Sub

It goes wrong in the line "Workbooks(bestandsnaam).Close
savechanges:=False"

What am I doing wrong?

Thanks for help, Gert-Jan




Tom Ogilvy

Closing a file
 
If it worked previously, then it should work this way.

this demo from the immediate window shows that it worked fine for me:

bestandsnaam = "C:\Data\TestPassword.xls"
? bestandsnaam
C:\Data\TestPassword.xls
set bk = workbooks.Open(Filename:=bestandsnaam,Password:="A BC")
? bk.Name
TestPassword.xls



--
Regards,
Tom Ogilvy


"Gert-Jan" wrote:

Thanks Tom, but there is an error in:

set bk = Workbooks.Open( _
Filename:=bestandsnaam, Password:="XYZ")



"Tom Ogilvy" schreef in bericht
...
Sub importerendb()
Dim bk as Workbook
Dim bestandsnaam as String
Range("rekenvel!E2").Value = Range("rekenvel!b13").Value _
& "\" & importeren.databasescombo.Value & ".xls"
bestandsnaam = Range("rekenvel!E2").Value
set bk = Workbooks.Open( _
Filename:=bestandsnaam, Password:="XYZ")
For Each n In bk.Names
n.Delete
Next
Sheets(Array("lijstkerken", "database")).Move Befo=Workbooks( _
"myfile.xls").Sheets(1)
bk.Close savechanges:=False
Unload importeren
End Sub

--
Regards,
Tom Ogilvy


"Gert-Jan" wrote:

Hi,

I am using this for importing some sheets from a workbook. After
importing
the file must be closed.

Sub importerendb()
Range("rekenvel!E2").Value = Range("rekenvel!b13").Value & "\" &
importeren.databasescombo.Value & ".xls"
Dim bestandsnaam
bestandsnaam = Range("rekenvel!E2").Value
Workbooks.Open Filename:=bestandsnaam, Password:="XYZ"
For Each n In ActiveWorkbook.Names
n.Delete
Next
Sheets(Array("lijstkerken", "database")).Move Befo=Workbooks( _
"myfile.xls").Sheets(1)
Workbooks(bestandsnaam).Close savechanges:=False
Unload importeren
End Sub

It goes wrong in the line "Workbooks(bestandsnaam).Close
savechanges:=False"

What am I doing wrong?

Thanks for help, Gert-Jan






All times are GMT +1. The time now is 03:11 PM.

Powered by vBulletin® Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
ExcelBanter.com