ExcelBanter

ExcelBanter (https://www.excelbanter.com/)
-   Excel Programming (https://www.excelbanter.com/excel-programming/)
-   -   beforesave code working sometimes...... (https://www.excelbanter.com/excel-programming/390313-beforesave-code-working-sometimes.html)

awrex

beforesave code working sometimes......
 
Ok I had posted a question about some code (Subject: Code issue -
before_save() - Filename with date stamp - worksheet), to which I got it to
work but now it is causing my Excel to completely crash.

Any ideas??? Also Why do I get 2 vbok pop up boxes????

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)


MsgBox "You should see something renamed!!", vbOK

Sheet1.Name = "As of " & Format(Now(), "MM-DD-YYYY")

ChDir "<new dir path"
ActiveWorkbook.SaveAs _
"<MyFileName" & Format(Now(), "yyyymmdd")

End Sub


Jim Thomlinson

beforesave code working sometimes......
 
Your save as is calling a save which is going to be an issue. You need to
cancel the pending save make your changes disable events, save the book and
then re enable... something like this...

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
On error goto ErrorHandler
Application.enableevents = false
cancel = true
MsgBox "You should see something renamed!!", vbOK

Sheet1.Name = "As of " & Format(Now(), "MM-DD-YYYY")

ChDir "<new dir path"
ActiveWorkbook.SaveAs _
"<MyFileName" & Format(Now(), "yyyymmdd")
ErrorHandler:
Application.enableevents = true
End Sub
--
HTH...

Jim Thomlinson


"awrex" wrote:

Ok I had posted a question about some code (Subject: Code issue -
before_save() - Filename with date stamp - worksheet), to which I got it to
work but now it is causing my Excel to completely crash.

Any ideas??? Also Why do I get 2 vbok pop up boxes????

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)


MsgBox "You should see something renamed!!", vbOK

Sheet1.Name = "As of " & Format(Now(), "MM-DD-YYYY")

ChDir "<new dir path"
ActiveWorkbook.SaveAs _
"<MyFileName" & Format(Now(), "yyyymmdd")

End Sub


awrex

beforesave code working sometimes......
 
THANK YOU!!!!!
Works great. Would you happen to know of web reference that I can look at
regarding this.


"Jim Thomlinson" wrote:

Your save as is calling a save which is going to be an issue. You need to
cancel the pending save make your changes disable events, save the book and
then re enable... something like this...

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
On error goto ErrorHandler
Application.enableevents = false
cancel = true
MsgBox "You should see something renamed!!", vbOK

Sheet1.Name = "As of " & Format(Now(), "MM-DD-YYYY")

ChDir "<new dir path"
ActiveWorkbook.SaveAs _
"<MyFileName" & Format(Now(), "yyyymmdd")
ErrorHandler:
Application.enableevents = true
End Sub
--
HTH...

Jim Thomlinson


"awrex" wrote:

Ok I had posted a question about some code (Subject: Code issue -
before_save() - Filename with date stamp - worksheet), to which I got it to
work but now it is causing my Excel to completely crash.

Any ideas??? Also Why do I get 2 vbok pop up boxes????

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)


MsgBox "You should see something renamed!!", vbOK

Sheet1.Name = "As of " & Format(Now(), "MM-DD-YYYY")

ChDir "<new dir path"
ActiveWorkbook.SaveAs _
"<MyFileName" & Format(Now(), "yyyymmdd")

End Sub


Jim Thomlinson

beforesave code working sometimes......
 
Check out Chip's site. He covers events along with every other VBA ting under
the sun...

http://www.cpearson.com/excel/topic.htm
--
HTH...

Jim Thomlinson


"awrex" wrote:

THANK YOU!!!!!
Works great. Would you happen to know of web reference that I can look at
regarding this.


"Jim Thomlinson" wrote:

Your save as is calling a save which is going to be an issue. You need to
cancel the pending save make your changes disable events, save the book and
then re enable... something like this...

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
On error goto ErrorHandler
Application.enableevents = false
cancel = true
MsgBox "You should see something renamed!!", vbOK

Sheet1.Name = "As of " & Format(Now(), "MM-DD-YYYY")

ChDir "<new dir path"
ActiveWorkbook.SaveAs _
"<MyFileName" & Format(Now(), "yyyymmdd")
ErrorHandler:
Application.enableevents = true
End Sub
--
HTH...

Jim Thomlinson


"awrex" wrote:

Ok I had posted a question about some code (Subject: Code issue -
before_save() - Filename with date stamp - worksheet), to which I got it to
work but now it is causing my Excel to completely crash.

Any ideas??? Also Why do I get 2 vbok pop up boxes????

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)


MsgBox "You should see something renamed!!", vbOK

Sheet1.Name = "As of " & Format(Now(), "MM-DD-YYYY")

ChDir "<new dir path"
ActiveWorkbook.SaveAs _
"<MyFileName" & Format(Now(), "yyyymmdd")

End Sub



All times are GMT +1. The time now is 10:57 PM.

Powered by vBulletin® Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
ExcelBanter.com