ExcelBanter

ExcelBanter (https://www.excelbanter.com/)
-   Excel Programming (https://www.excelbanter.com/excel-programming/)
-   -   If Then not working (https://www.excelbanter.com/excel-programming/346475-if-then-not-working.html)

Joe Fish

If Then not working
 
Hi,
In the following block of code, a variable is compared to the active
cell, and then either of two macros run, and it loops. Not matter what
happens, though, only the macro "CreateHomeRun" runs. "CreateJumper"
never runs.
Any ideas?
Thanks,
Joe

Dim CellAbove As Range
Set CellAbove = ActiveCell.Offset(-1, 0)

Do Until ActiveCell = ""
If ActiveCell = CellAbove Then
CreateJumper
Else: CreateHomeRun
End If
Loop


Norman Jones

If Then not working
 
Hi Joe,

Your code fails beacuse the comparitor is an unchanging active cell.

Try something like:

'===========
Sub Tester001()
Dim rng As Range
Dim rCell As Range

Set rng = Range(ActiveCell, ActiveCell.End(xlDown))

For Each rCell In rng.Cells
With rCell
If IsEmpty(.Value) Then Exit Sub
If .Value = .Offset(-1).Value Then
CreateJumper
Else
CreateHomeRun
End If
End With
Next rCell

End Sub
'<<===========


---
Regards,
Norman



"Joe Fish" wrote in message
ups.com...
Hi,
In the following block of code, a variable is compared to the active
cell, and then either of two macros run, and it loops. Not matter what
happens, though, only the macro "CreateHomeRun" runs. "CreateJumper"
never runs.
Any ideas?
Thanks,
Joe

Dim CellAbove As Range
Set CellAbove = ActiveCell.Offset(-1, 0)

Do Until ActiveCell = ""
If ActiveCell = CellAbove Then
CreateJumper
Else: CreateHomeRun
End If
Loop




Joe Fish

If Then not working
 
Norman,
It works like a charm.
Thanks,
Joe



All times are GMT +1. The time now is 09:54 AM.

Powered by vBulletin® Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
ExcelBanter.com