ExcelBanter

ExcelBanter (https://www.excelbanter.com/)
-   Excel Programming (https://www.excelbanter.com/excel-programming/)
-   -   Why isn't this macro giving me proper results? (https://www.excelbanter.com/excel-programming/339558-why-isnt-macro-giving-me-proper-results.html)

Girish

Why isn't this macro giving me proper results?
 
Good Morning,

Can someone please look in and spot the problem. Basixcally what I'm trying
to do here is to filter a range of dates.

But what actually happens when I run this code is that the Excel filters for
"From1" and "To1" literally (as text/string) and not for values stored in
these range variables.

Solution Please.....

Sub Macro3()
Dim From1, To1 As Range
With Application
.Calculation = xlManual
.MaxChange = 0.001
End With
Set From1 = Worksheets("Individual").Range("E45")
Set To1 = Worksheets("Individual").Range("K45")
Sheets("Quality Check Log").Select
Range("A3").Select
Selection.AutoFilter Field:=1, Criteria1:="=From1", Operator:=xlAnd,
Criteria2:="<=To1"
End Sub


--
Thanks,
Girish
Bangalore, India

Tushar Mehta

Why isn't this macro giving me proper results?
 
In article ,
says...
Good Morning,

Can someone please look in and spot the problem. Basixcally what I'm trying
to do here is to filter a range of dates.

But what actually happens when I run this code is that the Excel filters for
"From1" and "To1" literally (as text/string) and not for values stored in
these range variables.

Solution Please.....

Sub Macro3()
Dim From1, To1 As Range
With Application
.Calculation = xlManual
.MaxChange = 0.001
End With
Set From1 = Worksheets("Individual").Range("E45")
Set To1 = Worksheets("Individual").Range("K45")
Sheets("Quality Check Log").Select
Range("A3").Select
Selection.AutoFilter Field:=1, Criteria1:="=From1", Operator:=xlAnd,
Criteria2:="<=To1"
End Sub



Untested suggestion.
Selection.AutoFilter Field:=1, Criteria1:="=" & From1.Value, _
Operator:=xlAnd, Criteria2:="<=" & To1.Value

--
Regards,

Tushar Mehta
www.tushar-mehta.com
Excel, PowerPoint, and VBA add-ins, tutorials
Custom MS Office productivity solutions

Dave Peterson

Why isn't this macro giving me proper results?
 
And just to add to Tushar's response--sometimes autofilter has trouble with
dates:

Selection.AutoFilter Field:=1, Criteria1:="=" & clng(From1.Value), _
Operator:=xlAnd, Criteria2:="<=" & clng(To1.Value)



Girish wrote:

Good Morning,

Can someone please look in and spot the problem. Basixcally what I'm trying
to do here is to filter a range of dates.

But what actually happens when I run this code is that the Excel filters for
"From1" and "To1" literally (as text/string) and not for values stored in
these range variables.

Solution Please.....

Sub Macro3()
Dim From1, To1 As Range
With Application
.Calculation = xlManual
.MaxChange = 0.001
End With
Set From1 = Worksheets("Individual").Range("E45")
Set To1 = Worksheets("Individual").Range("K45")
Sheets("Quality Check Log").Select
Range("A3").Select
Selection.AutoFilter Field:=1, Criteria1:="=From1", Operator:=xlAnd,
Criteria2:="<=To1"
End Sub

--
Thanks,
Girish
Bangalore, India


--

Dave Peterson

Girish

Why isn't this macro giving me proper results?
 
Thanks a ton guys, both your suggestions are working. great.
--
Girish Bhatta V.
Bangalore, India


"Tushar Mehta" wrote:

In article ,
says...
Good Morning,

Can someone please look in and spot the problem. Basixcally what I'm trying
to do here is to filter a range of dates.

But what actually happens when I run this code is that the Excel filters for
"From1" and "To1" literally (as text/string) and not for values stored in
these range variables.

Solution Please.....

Sub Macro3()
Dim From1, To1 As Range
With Application
.Calculation = xlManual
.MaxChange = 0.001
End With
Set From1 = Worksheets("Individual").Range("E45")
Set To1 = Worksheets("Individual").Range("K45")
Sheets("Quality Check Log").Select
Range("A3").Select
Selection.AutoFilter Field:=1, Criteria1:="=From1", Operator:=xlAnd,
Criteria2:="<=To1"
End Sub



Untested suggestion.
Selection.AutoFilter Field:=1, Criteria1:="=" & From1.Value, _
Operator:=xlAnd, Criteria2:="<=" & To1.Value

--
Regards,

Tushar Mehta
www.tushar-mehta.com
Excel, PowerPoint, and VBA add-ins, tutorials
Custom MS Office productivity solutions



All times are GMT +1. The time now is 04:28 AM.

Powered by vBulletin® Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
ExcelBanter.com