ExcelBanter

ExcelBanter (https://www.excelbanter.com/)
-   Excel Programming (https://www.excelbanter.com/excel-programming/)
-   -   Help with Simple Function (https://www.excelbanter.com/excel-programming/338825-help-simple-function.html)

Tomski[_2_]

Help with Simple Function
 

Hi guys,

Am new to this forum but could do with some help. I've just starte
working in a bank and need to sharpen up on my excel. I'm not new t
programming, but am to VB and its syntax. Also I've never been ver
good at debugging.

Anyway trying to write a simple function that takes a range then count
the number of time a string occurs in it. Heres my code:

Function CountStr(ran As Range, Str As String) As Integer

Dim temp As Integer
temp = 0
For Each x In ran
If x = Str Then temp = temp + 1
End If
Next x

CountStr = temp
End Function


Any ideas of why this is throwing an error, I'm sure its somethin
simple. Any help would be nice.

Thanks

To

--
Tomsk
-----------------------------------------------------------------------
Tomski's Profile: http://www.excelforum.com/member.php...fo&userid=2682
View this thread: http://www.excelforum.com/showthread.php?threadid=40075


dominicb[_105_]

Help with Simple Function
 

Good afternoon Tomski

The problem is in your End If line. Take it out and your function wil
work fine.

You function could phrase your If statement like this:

If x = Str Then
temp = temp + 1
End If

or like this:

If x = Str Then temp = temp + 1

but not a combination of the two.

Or you could use the =COUNTIF() function to get the job done

HTH

Dominic

--
dominic
-----------------------------------------------------------------------
dominicb's Profile: http://www.excelforum.com/member.php...fo&userid=1893
View this thread: http://www.excelforum.com/showthread.php?threadid=40075


Tomski[_3_]

Help with Simple Function
 

Nice one, Cheers for that!

T


--
Tomski
------------------------------------------------------------------------
Tomski's Profile: http://www.excelforum.com/member.php...o&userid=26824
View this thread: http://www.excelforum.com/showthread...hreadid=400754


dominicb[_106_]

Help with Simple Function
 

Hi Tomski

You're welcome. Thanks for the feedback.

DominicB


--
dominicb
------------------------------------------------------------------------
dominicb's Profile: http://www.excelforum.com/member.php...o&userid=18932
View this thread: http://www.excelforum.com/showthread...hreadid=400754



All times are GMT +1. The time now is 01:18 PM.

Powered by vBulletin® Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
ExcelBanter.com