ExcelBanter

ExcelBanter (https://www.excelbanter.com/)
-   Excel Programming (https://www.excelbanter.com/excel-programming/)
-   -   Getting data efficiently (https://www.excelbanter.com/excel-programming/309308-getting-data-efficiently.html)

MAB[_6_]

Getting data efficiently
 
I've written some VBA code that gets data from an Oracle database. So for
each VisitID in the excel sheet starting from C10 it runs a query in a loop
and gets the date of visit ( dated) and puts that next to the visitID. heres
the code

col = "C"
row = 10

cell = col & CStr(row)

Do While Range(cell) < ""

visitID = Range(cell)

sql = "select dated " & _
"from visit v, patient p " & _
"where v.patient_id = p.patient_id " & _
"and visit_id = " & visitID


rs.Open sql

If Not rs.EOF Then

Range(cell).Offset(0, 1) = rs("dated")

Else

Range(cell).Offset(0, 1) = ""

End If

rs.Close

row = row + 1
cell = col & CStr(row)

Loop

So the same query gets compiled and executed for each visitID. This is slow
and there must be a better method to get such data.
any ideas appreciated.

thx




All times are GMT +1. The time now is 12:12 AM.

Powered by vBulletin® Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
ExcelBanter.com